[libcamera-devel,v7,1/5] ipa: ipu3: Extend ipu3 ipa interface for lens controls
diff mbox series

Message ID 20211202140317.3118364-2-hanlinchen@chromium.org
State Accepted
Headers show
Series
  • Introduce Lens class and apply auto focus on ipu3
Related show

Commit Message

Hanlin Chen Dec. 2, 2021, 2:03 p.m. UTC 
IPU3Event and IPU3Action use two fields for both libcamera controls and sensor
V4L2 controls. The patch extend one more field for lens V4L2 controls
for auto focus usage.

Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 include/libcamera/ipa/ipu3.mojom | 2 ++
 1 file changed, 2 insertions(+)

Comments

Umang Jain Dec. 2, 2021, 5 p.m. UTC | #1 
Hi Han-Lin

On 12/2/21 7:33 PM, Han-Lin Chen wrote:
> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor
> V4L2 controls. The patch extend one more field for lens V4L2 controls
> for auto focus usage.
>
> Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   include/libcamera/ipa/ipu3.mojom | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom
> index 16e3462e..cc0d822f 100644
> --- a/include/libcamera/ipa/ipu3.mojom
> +++ b/include/libcamera/ipa/ipu3.mojom
> @@ -24,12 +24,14 @@ struct IPU3Event {
>   	uint32 bufferId;
>   	libcamera.ControlList controls;
>   	libcamera.ControlList sensorControls;
> +	libcamera.ControlList lensControls;
>   };
>   
>   struct IPU3Action {
>   	IPU3Operations op;
>   	libcamera.ControlList controls;
>   	libcamera.ControlList sensorControls;
> +	libcamera.ControlList lensControls;
>   };
>   
>   struct IPAConfigInfo {

Patch
diff mbox series 

diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom
index 16e3462e..cc0d822f 100644
--- a/include/libcamera/ipa/ipu3.mojom
+++ b/include/libcamera/ipa/ipu3.mojom
@@ -24,12 +24,14 @@  struct IPU3Event {
 	uint32 bufferId;
 	libcamera.ControlList controls;
 	libcamera.ControlList sensorControls;
+	libcamera.ControlList lensControls;
 };
 
 struct IPU3Action {
 	IPU3Operations op;
 	libcamera.ControlList controls;
 	libcamera.ControlList sensorControls;
+	libcamera.ControlList lensControls;
 };
 
 struct IPAConfigInfo {