| Message ID | 20190610220759.7192-1-kieran.bingham@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | a0f869f4ed92144aed6f8d9ad8f06eb02f365939 |
| Headers | show |
| Series |
|
| Related | show |
Hello, On Mon, Jun 10, 2019 at 11:07:57PM +0100, Kieran Bingham wrote: > The PipelineHandler::completeBuffer documentation repeats the word > 'request'. > > Remove the duplication and reformat the lines to fit. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/libcamera/pipeline_handler.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp > index af19f4a33187..c91ef2f7d336 100644 > --- a/src/libcamera/pipeline_handler.cpp > +++ b/src/libcamera/pipeline_handler.cpp > @@ -391,8 +391,8 @@ bool PipelineHandler::completeBuffer(Camera *camera, Request *request, > * \param[in] request The request that has completed > * > * The pipeline handler shall call this method to notify the \a camera that the > - * request request has complete. The request is deleted and shall not be > - * accessed once this method returns. > + * request has completed. The request is deleted and shall not be accessed once > + * this method returns. > * > * The pipeline handler shall ensure that requests complete in the same order > * they are submitted. > -- > 2.20.1 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Jacopo, Thanks for glancing over this trivial series. I've pushed the patches with your tags, and reduced my backlog :-D -- Kieran On 11/06/2019 07:07, Jacopo Mondi wrote: > Hello, > > On Mon, Jun 10, 2019 at 11:07:57PM +0100, Kieran Bingham wrote: >> The PipelineHandler::completeBuffer documentation repeats the word >> 'request'. >> >> Remove the duplication and reformat the lines to fit. >> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> > > Thanks > j > >> --- >> src/libcamera/pipeline_handler.cpp | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp >> index af19f4a33187..c91ef2f7d336 100644 >> --- a/src/libcamera/pipeline_handler.cpp >> +++ b/src/libcamera/pipeline_handler.cpp >> @@ -391,8 +391,8 @@ bool PipelineHandler::completeBuffer(Camera *camera, Request *request, >> * \param[in] request The request that has completed >> * >> * The pipeline handler shall call this method to notify the \a camera that the >> - * request request has complete. The request is deleted and shall not be >> - * accessed once this method returns. >> + * request has completed. The request is deleted and shall not be accessed once >> + * this method returns. >> * >> * The pipeline handler shall ensure that requests complete in the same order >> * they are submitted. >> -- >> 2.20.1 >> >> _______________________________________________ >> libcamera-devel mailing list >> libcamera-devel@lists.libcamera.org >> https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index af19f4a33187..c91ef2f7d336 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -391,8 +391,8 @@ bool PipelineHandler::completeBuffer(Camera *camera, Request *request, * \param[in] request The request that has completed * * The pipeline handler shall call this method to notify the \a camera that the - * request request has complete. The request is deleted and shall not be - * accessed once this method returns. + * request has completed. The request is deleted and shall not be accessed once + * this method returns. * * The pipeline handler shall ensure that requests complete in the same order * they are submitted.
The PipelineHandler::completeBuffer documentation repeats the word 'request'. Remove the duplication and reformat the lines to fit. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/libcamera/pipeline_handler.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)