From patchwork Mon Jun 10 22:07:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 1389 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DDD661E49 for ; Tue, 11 Jun 2019 00:08:04 +0200 (CEST) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 82C2F9CB; Tue, 11 Jun 2019 00:08:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1560204483; bh=+iVOT40c42yVBP6yijbsBRpQJ+jEwNaTOhGGALQiXKU=; h=From:To:Cc:Subject:Date:From; b=cn0+BG4DBy8OdJUAtV2SWqOM26pDcdTkMPd5g5oTdsgTpHoGSDsg49tgFUOH7MzI3 408i0nojEkGZRPvCWyLD3O4kR6rGNIKVJHglcnRs7NgXwoXbCWsNXUz/4pgqwYD4BM 4GfqSV0LLnKmUu+7pYzcvn8CPgD3ZT/7DNFDy1ZM= From: Kieran Bingham To: LibCamera Devel Date: Mon, 10 Jun 2019 23:07:57 +0100 Message-Id: <20190610220759.7192-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] libcamera: pipeline: Fix 'request' grammar X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2019 22:08:04 -0000 The PipelineHandler::completeBuffer documentation repeats the word 'request'. Remove the duplication and reformat the lines to fit. Signed-off-by: Kieran Bingham Reviewed-by: Jacopo Mondi --- src/libcamera/pipeline_handler.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index af19f4a33187..c91ef2f7d336 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -391,8 +391,8 @@ bool PipelineHandler::completeBuffer(Camera *camera, Request *request, * \param[in] request The request that has completed * * The pipeline handler shall call this method to notify the \a camera that the - * request request has complete. The request is deleted and shall not be - * accessed once this method returns. + * request has completed. The request is deleted and shall not be accessed once + * this method returns. * * The pipeline handler shall ensure that requests complete in the same order * they are submitted. From patchwork Mon Jun 10 22:07:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 1390 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5501F61FBF for ; Tue, 11 Jun 2019 00:08:04 +0200 (CEST) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D3BB7E58; Tue, 11 Jun 2019 00:08:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1560204484; bh=mQJunhcUrXhXnKphxYvUBiWxyeD/eIQXW3qH2uU75+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jhVA2ulrQDXKbIONGx0OzamuncyV08FRb95gd63HP8KMWgf+OzfA4MUjT9jSGPHOM T/bUW/SGTFQFUCykwNbaZcu79AR9Y1/R62OJ2ILChxCIT4G50eSS1OyuFdHy6Y9KYH jlmBrcWijPwsnbi49gAsj2dg9Qnx7RR+LXjZrt48= From: Kieran Bingham To: LibCamera Devel Date: Mon, 10 Jun 2019 23:07:58 +0100 Message-Id: <20190610220759.7192-2-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190610220759.7192-1-kieran.bingham@ideasonboard.com> References: <20190610220759.7192-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: ipu3: Fix spelling X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2019 22:08:04 -0000 Fix trivial spelling of queueing. Signed-off-by: Kieran Bingham Acked-by: Jacopo Mondi --- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 05005c42106b..f2bdecbac20f 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -909,7 +909,7 @@ void IPU3CameraData::imguOutputBufferReady(Buffer *buffer) /* Request not completed yet, return here. */ return; - /* Complete the pending requests in queuing order. */ + /* Complete the pending requests in queueing order. */ while (1) { request = queuedRequests_.front(); if (request->hasPendingBuffers()) From patchwork Mon Jun 10 22:07:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 1391 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BB1F61E49 for ; Tue, 11 Jun 2019 00:08:04 +0200 (CEST) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2670DE77; Tue, 11 Jun 2019 00:08:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1560204484; bh=NNG6zcc98oHkm6qjcXSCBxDDgH3G97Aveg6n358/IO8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L3ov5u3irs87O+iYpIqi+x9fQkkLOpC535+tIcgdAx8fI5qNc4fDXXVn4hPXU43vQ GZafucDo0FifksYHdJw79t3ThshmTy/5PDGa+toaOCk5o5XGdE2cE+LgRX9MJHMl+9 eoZVzPfv//m8uFz3yfQDUVcZnmniRor21Y2jxAbM= From: Kieran Bingham To: LibCamera Devel Date: Mon, 10 Jun 2019 23:07:59 +0100 Message-Id: <20190610220759.7192-3-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190610220759.7192-1-kieran.bingham@ideasonboard.com> References: <20190610220759.7192-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] libcamera: geometry: Fix SizeRange constructor style X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2019 22:08:04 -0000 Match the style of the SizeRange() which specifies the hStep and vStep, and wrap the lines in pairs of min and max values. Signed-off-by: Kieran Bingham Reviewed-by: Jacopo Mondi --- src/libcamera/geometry.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp index 97c367bcb454..fb8f628a0d8a 100644 --- a/src/libcamera/geometry.cpp +++ b/src/libcamera/geometry.cpp @@ -197,7 +197,8 @@ bool operator<(const Size &lhs, const Size &rhs) */ /** - * \fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH) + * \fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, + * unsigned int maxW, unsigned int maxH) * \brief Construct an initialized size range * \param[in] minW The minimum width * \param[in] minH The minimum height