[libcamera-devel,2/2] ipa: raspberrypi: Fix enumeration numbers
diff mbox series

Message ID 20210418172712.61536-2-sebastian.fricke@posteo.net
State Rejected
Headers show
Series
  • [libcamera-devel,1/2] ipa: cam_helper_imx219: Rework comment
Related show

Commit Message

Sebastian Fricke April 18, 2021, 5:27 p.m. UTC
The README.md tries to list possibilities for the user with an
enumeration but it always uses the number 1 for each point. Fix it.

Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>
---
 src/ipa/raspberrypi/README.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Laurent Pinchart April 18, 2021, 7:39 p.m. UTC | #1
Hi Sebastian,

Thank you for the patch.

On Sun, Apr 18, 2021 at 05:27:11PM +0000, Sebastian Fricke wrote:
> The README.md tries to list possibilities for the user with an
> enumeration but it always uses the number 1 for each point. Fix it.

https://www.markdownguide.org/basic-syntax/#ordered-lists

> Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>
> ---
>  src/ipa/raspberrypi/README.md | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/README.md b/src/ipa/raspberrypi/README.md
> index 26534af0..cfddfc4c 100644
> --- a/src/ipa/raspberrypi/README.md
> +++ b/src/ipa/raspberrypi/README.md
> @@ -9,11 +9,11 @@ included for all existing Raspberry Pi camera modules.
>  _libcamera_ for the Raspberry Pi allows users to:
>  
>  1. Use their existing Raspberry Pi cameras.
> -1. Change the tuning of the image processing for their Raspberry Pi cameras.
> -1. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)
> +2. Change the tuning of the image processing for their Raspberry Pi cameras.
> +3. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)
>     that control the sensor and ISP.
> -1. Implement their own custom control algorithms.
> -1. Supply new tunings and/or algorithms for completely new sensors.
> +4. Implement their own custom control algorithms.
> +5. Supply new tunings and/or algorithms for completely new sensors.
>  
>  ## How to install and run _libcamera_ on the Raspberry Pi
>
Sebastian Fricke April 19, 2021, 4:09 a.m. UTC | #2
On 18.04.2021 22:39, Laurent Pinchart wrote:
>Hi Sebastian,
>
>Thank you for the patch.
>
>On Sun, Apr 18, 2021 at 05:27:11PM +0000, Sebastian Fricke wrote:
>> The README.md tries to list possibilities for the user with an
>> enumeration but it always uses the number 1 for each point. Fix it.
>
>https://www.markdownguide.org/basic-syntax/#ordered-lists

Okay thank you good to know, I will keep that in mind.

Greetings,
Sebastian

>
>> Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>
>> ---
>>  src/ipa/raspberrypi/README.md | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/ipa/raspberrypi/README.md b/src/ipa/raspberrypi/README.md
>> index 26534af0..cfddfc4c 100644
>> --- a/src/ipa/raspberrypi/README.md
>> +++ b/src/ipa/raspberrypi/README.md
>> @@ -9,11 +9,11 @@ included for all existing Raspberry Pi camera modules.
>>  _libcamera_ for the Raspberry Pi allows users to:
>>
>>  1. Use their existing Raspberry Pi cameras.
>> -1. Change the tuning of the image processing for their Raspberry Pi cameras.
>> -1. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)
>> +2. Change the tuning of the image processing for their Raspberry Pi cameras.
>> +3. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)
>>     that control the sensor and ISP.
>> -1. Implement their own custom control algorithms.
>> -1. Supply new tunings and/or algorithms for completely new sensors.
>> +4. Implement their own custom control algorithms.
>> +5. Supply new tunings and/or algorithms for completely new sensors.
>>
>>  ## How to install and run _libcamera_ on the Raspberry Pi
>>
>
>-- 
>Regards,
>
>Laurent Pinchart

Patch
diff mbox series

diff --git a/src/ipa/raspberrypi/README.md b/src/ipa/raspberrypi/README.md
index 26534af0..cfddfc4c 100644
--- a/src/ipa/raspberrypi/README.md
+++ b/src/ipa/raspberrypi/README.md
@@ -9,11 +9,11 @@  included for all existing Raspberry Pi camera modules.
 _libcamera_ for the Raspberry Pi allows users to:
 
 1. Use their existing Raspberry Pi cameras.
-1. Change the tuning of the image processing for their Raspberry Pi cameras.
-1. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)
+2. Change the tuning of the image processing for their Raspberry Pi cameras.
+3. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others)
    that control the sensor and ISP.
-1. Implement their own custom control algorithms.
-1. Supply new tunings and/or algorithms for completely new sensors.
+4. Implement their own custom control algorithms.
+5. Supply new tunings and/or algorithms for completely new sensors.
 
 ## How to install and run _libcamera_ on the Raspberry Pi