From patchwork Sun Apr 18 17:27:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Fricke X-Patchwork-Id: 11979 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BE9CABD812 for ; Sun, 18 Apr 2021 17:27:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 24D27605AE; Sun, 18 Apr 2021 19:27:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=posteo.net header.i=@posteo.net header.b="Oyu/G5wq"; dkim-atps=neutral Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ABC45602CA for ; Sun, 18 Apr 2021 19:27:27 +0200 (CEST) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 24AFE2400FE for ; Sun, 18 Apr 2021 19:27:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618766847; bh=ROc3NZgb6GBD58DM+ckfCws7cWfAyFxs4DxurjsMWec=; h=From:To:Cc:Subject:Date:From; b=Oyu/G5wqeVctkAhiSQFt0n6AYMRFgNeNJXwDqYxd1VWOAlnZ/hnO3yS4ERVg8Fju4 G8+pu9FPez/zSKP3ukFHq6Eb2D6/ybmJCa179jw3kwJ00cEYBOQ+nEa43htlfb8i7h 7/nOaJvQBxRw8MfJgXdwOCa61nFUADOaL7DXdvAP4wzKWe9aG4kLOYKgzrzrOwTVyq xG4ZNZ6GZdCHoFARMNedI/o8J6rd+3zkc6MD1Yrkpf/+bu0w0xCBIOwnfTpHT8iALw Sm+m6vvb7iXBfoiOyv+6fVoWtOjLPat/4xGMGfy0KM8503ns3RBVWg4rK+7yvX068o V8+dn1IT6WNTQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FNcMf34Mpz9rxM; Sun, 18 Apr 2021 19:27:26 +0200 (CEST) From: Sebastian Fricke To: libcamera-devel@lists.libcamera.org Date: Sun, 18 Apr 2021 17:27:10 +0000 Message-Id: <20210418172712.61536-1-sebastian.fricke@posteo.net> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] ipa: cam_helper_imx219: Rework comment X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fix two typos and improve the sentence. Signed-off-by: Sebastian Fricke Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/cam_helper_imx219.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/cam_helper_imx219.cpp b/src/ipa/raspberrypi/cam_helper_imx219.cpp index 0e454d0d..ecd56455 100644 --- a/src/ipa/raspberrypi/cam_helper_imx219.cpp +++ b/src/ipa/raspberrypi/cam_helper_imx219.cpp @@ -11,8 +11,8 @@ #include /* - * We have observed the imx219 embedded data stream randomly return junk - * reister values. Do not rely on embedded data until this has been resolved. + * We have observed that the imx219 embedded data stream randomly returns junk + * register values. Do not rely on embedded data until this has been resolved. */ #define ENABLE_EMBEDDED_DATA 0 From patchwork Sun Apr 18 17:27:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Fricke X-Patchwork-Id: 11980 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BD688BD812 for ; Sun, 18 Apr 2021 17:27:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 805C16880B; Sun, 18 Apr 2021 19:27:38 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=posteo.net header.i=@posteo.net header.b="FL+1fL6A"; dkim-atps=neutral Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 434AE602CA for ; Sun, 18 Apr 2021 19:27:37 +0200 (CEST) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id CF70F2400FE for ; Sun, 18 Apr 2021 19:27:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618766856; bh=8kT9eJnu8Qk9tEw6w8DEXOCzjCl2NB49TXgaaiMOCKs=; h=From:To:Cc:Subject:Date:From; b=FL+1fL6AyfB0EAaEBQj3t8lx8B+kWGQKUXC2QJROyBV/I/M0PBUnwIW7G/Vch1NbZ BRsJECBWdwT7aHQaoPKs9OU4GDWtjD5Ge6gERhMaZ8r0NDEY4BmCZ9qHwGFVlSBZhd p+a/PD5l/jNiBR0ghyndAYGJZH72I2hWCIIMQOTfCPUHLfpH6Qy8VgW4IsWjo1WPij +hMM8zN8PtdLfvcADu38459GPIQthrlT0vqqjLZ1WdvIWtm8tpjTonKWFoMT8U8ad2 cG5p+ySxOshtaDKvVkTAwZL0e5pNbE1DegRtsLt8QGuGT0nVVImOeMCAW49hy1ai0E dbZSH/kF9mdXg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FNcMq4C7Nz9rxM; Sun, 18 Apr 2021 19:27:35 +0200 (CEST) From: Sebastian Fricke To: libcamera-devel@lists.libcamera.org Date: Sun, 18 Apr 2021 17:27:11 +0000 Message-Id: <20210418172712.61536-2-sebastian.fricke@posteo.net> In-Reply-To: <20210418172712.61536-1-sebastian.fricke@posteo.net> References: <20210418172712.61536-1-sebastian.fricke@posteo.net> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: Fix enumeration numbers X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The README.md tries to list possibilities for the user with an enumeration but it always uses the number 1 for each point. Fix it. Signed-off-by: Sebastian Fricke --- src/ipa/raspberrypi/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/raspberrypi/README.md b/src/ipa/raspberrypi/README.md index 26534af0..cfddfc4c 100644 --- a/src/ipa/raspberrypi/README.md +++ b/src/ipa/raspberrypi/README.md @@ -9,11 +9,11 @@ included for all existing Raspberry Pi camera modules. _libcamera_ for the Raspberry Pi allows users to: 1. Use their existing Raspberry Pi cameras. -1. Change the tuning of the image processing for their Raspberry Pi cameras. -1. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others) +2. Change the tuning of the image processing for their Raspberry Pi cameras. +3. Alter or amend the control algorithms (such as AGC/AEC, AWB or any others) that control the sensor and ISP. -1. Implement their own custom control algorithms. -1. Supply new tunings and/or algorithms for completely new sensors. +4. Implement their own custom control algorithms. +5. Supply new tunings and/or algorithms for completely new sensors. ## How to install and run _libcamera_ on the Raspberry Pi