| Message ID | 20210414180256.10724-2-sebastian.fricke@posteo.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Sebastian, Thank you for the patch. On Wed, Apr 14, 2021 at 08:02:58PM +0200, Sebastian Fricke wrote: > Sensors provide embedded buffers and not metadata buffers, replace the > incorrect term with the correct one. > > Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net> > --- > src/ipa/raspberrypi/cam_helper.hpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp > index eaf73019..2ab3d49f 100644 > --- a/src/ipa/raspberrypi/cam_helper.hpp > +++ b/src/ipa/raspberrypi/cam_helper.hpp > @@ -35,7 +35,7 @@ namespace RPiController { > // > // A method to query if the sensor outputs embedded data that can be parsed. > // > -// A parser to parse the metadata buffers provided by some sensors (for > +// A parser to parse the embedded buffers provided by some sensors (for The correct term would be "embedded data", not just "embedded". That's a form of metadata though. I don't mind much either way, let's say what David prefers. > // example, the imx219 does; the ov5647 doesn't). This allows us to know for > // sure the exposure and gain of the frame we're looking at. CamHelper > // provides methods for converting analogue gains to and from the sensor's
Hi Sebastian, Laurent, Thanks for proposing this change. On Wed, 14 Apr 2021 at 23:44, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Sebastian, > > Thank you for the patch. > > On Wed, Apr 14, 2021 at 08:02:58PM +0200, Sebastian Fricke wrote: > > Sensors provide embedded buffers and not metadata buffers, replace the > > incorrect term with the correct one. > > > > Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net> > > --- > > src/ipa/raspberrypi/cam_helper.hpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp > > index eaf73019..2ab3d49f 100644 > > --- a/src/ipa/raspberrypi/cam_helper.hpp > > +++ b/src/ipa/raspberrypi/cam_helper.hpp > > @@ -35,7 +35,7 @@ namespace RPiController { > > // > > // A method to query if the sensor outputs embedded data that can be parsed. > > // > > -// A parser to parse the metadata buffers provided by some sensors (for > > +// A parser to parse the embedded buffers provided by some sensors (for > > The correct term would be "embedded data", not just "embedded". That's a > form of metadata though. I don't mind much either way, let's say what > David prefers. At the moment these buffers only ever contain the sensor's register dumps, though there's a patch already in the pipeline that allows them to be more general, containing different kinds of image statistics or the results of on-sensor image analysis algorithms. If we're happy to describe all these as "embedded data buffers" then the change sounds good to me. Actually, I quite like using "embedded data buffers" to refer to these buffers from the sensor, rather than "metadata buffers". The term "metadata" gets thrown around rather too much (blaming myself here!) so terminology that immediately tells you it's straight from the sensor seems clearer. Assuming then that "embedded data buffers" makes sense to everyone else: Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Thanks! David > > > // example, the imx219 does; the ov5647 doesn't). This allows us to know for > > // sure the exposure and gain of the frame we're looking at. CamHelper > > // provides methods for converting analogue gains to and from the sensor's > > -- > Regards, > > Laurent Pinchart > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hey David and Laurent, On 15.04.2021 09:04, David Plowman wrote: >Hi Sebastian, Laurent, > >Thanks for proposing this change. > >On Wed, 14 Apr 2021 at 23:44, Laurent Pinchart ><laurent.pinchart@ideasonboard.com> wrote: >> >> Hi Sebastian, >> >> Thank you for the patch. >> >> On Wed, Apr 14, 2021 at 08:02:58PM +0200, Sebastian Fricke wrote: >> > Sensors provide embedded buffers and not metadata buffers, replace the >> > incorrect term with the correct one. >> > >> > Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net> >> > --- >> > src/ipa/raspberrypi/cam_helper.hpp | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp >> > index eaf73019..2ab3d49f 100644 >> > --- a/src/ipa/raspberrypi/cam_helper.hpp >> > +++ b/src/ipa/raspberrypi/cam_helper.hpp >> > @@ -35,7 +35,7 @@ namespace RPiController { >> > // >> > // A method to query if the sensor outputs embedded data that can be parsed. >> > // >> > -// A parser to parse the metadata buffers provided by some sensors (for >> > +// A parser to parse the embedded buffers provided by some sensors (for >> >> The correct term would be "embedded data", not just "embedded". That's a >> form of metadata though. I don't mind much either way, let's say what >> David prefers. @Laurent Okay I think embedded data buffer ist better than embedded buffer. Do you change that before applying the patch or would you like to get a v2? > >At the moment these buffers only ever contain the sensor's register >dumps, though there's a patch already in the pipeline that allows them >to be more general, containing different kinds of image statistics or >the results of on-sensor image analysis algorithms. > >If we're happy to describe all these as "embedded data buffers" then >the change sounds good to me. Actually, I quite like using "embedded >data buffers" to refer to these buffers from the sensor, rather than >"metadata buffers". The term "metadata" gets thrown around rather too >much (blaming myself here!) so terminology that immediately tells you >it's straight from the sensor seems clearer. Assuming then that >"embedded data buffers" makes sense to everyone else: @David Thank you for making this clear, I currently read a lot of those comments across the RPi implementation, I will make sure to change metadata buffer references to embedded data buffer references, whenever I spot them. > >Reviewed-by: David Plowman <david.plowman@raspberrypi.com> > >Thanks! > >David Greetings, Sebastian > >> >> > // example, the imx219 does; the ov5647 doesn't). This allows us to know for >> > // sure the exposure and gain of the frame we're looking at. CamHelper >> > // provides methods for converting analogue gains to and from the sensor's >> >> -- >> Regards, >> >> Laurent Pinchart >> _______________________________________________ >> libcamera-devel mailing list >> libcamera-devel@lists.libcamera.org >> https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp index eaf73019..2ab3d49f 100644 --- a/src/ipa/raspberrypi/cam_helper.hpp +++ b/src/ipa/raspberrypi/cam_helper.hpp @@ -35,7 +35,7 @@ namespace RPiController { // // A method to query if the sensor outputs embedded data that can be parsed. // -// A parser to parse the metadata buffers provided by some sensors (for +// A parser to parse the embedded buffers provided by some sensors (for // example, the imx219 does; the ov5647 doesn't). This allows us to know for // sure the exposure and gain of the frame we're looking at. CamHelper // provides methods for converting analogue gains to and from the sensor's
Sensors provide embedded buffers and not metadata buffers, replace the incorrect term with the correct one. Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net> --- src/ipa/raspberrypi/cam_helper.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)