From patchwork Wed Apr 14 18:02:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Fricke X-Patchwork-Id: 11931 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6AB5ABD1F6 for ; Wed, 14 Apr 2021 18:03:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C456E6880A; Wed, 14 Apr 2021 20:03:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=posteo.net header.i=@posteo.net header.b="K2B3fyu6"; dkim-atps=neutral Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D429168803 for ; Wed, 14 Apr 2021 20:03:28 +0200 (CEST) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 5D3451A022C for ; Wed, 14 Apr 2021 20:03:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618423407; bh=YjdHj+cpAhrG1Kb7poLqMGOZKxMDcocmoPgXJx+P51A=; h=From:To:Cc:Subject:Date:From; b=K2B3fyu6o92Fr1hXm8oSgWVsakgZu5Vb5D9K01NW5NnHv7C+7Ctnlv4xPyHpg9Lm0 0PBsC44rO1XfV2/EzPAA0jHvumfPiMbwljv67eEQ/eejYohbjPWZeTZSpP/uUrJSFw JjAPi4FKRpqia06jaEDCClIae9Vkf/udrlQ8bo/nUTJciQBjPh5RM8pHFyIhbqGtqf 8hv37hIADKZ3ZPFwF5FCfpXZxphdsVhJYVrsCeozsPB2Hs4Q8p1DQBbIOTo+6XRLWU LKwaa7mq0QqBNiaBttqrdtwsgtoXbSQd4ojzhSSkZvCeRHi74k9FiJAmwxDNJwyek2 nhrMuy+uaYs6g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FL9M247kVz6tm9; Wed, 14 Apr 2021 20:03:26 +0200 (CEST) From: Sebastian Fricke To: libcamera-devel@lists.libcamera.org Date: Wed, 14 Apr 2021 20:02:56 +0200 Message-Id: <20210414180256.10724-1-sebastian.fricke@posteo.net> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] ipa: cam_helper.hpp: Remove duplicate words X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Sebastian Fricke Reviewed-by: Laurent Pinchart Reviewed-by: Naushir Patuck --- src/ipa/raspberrypi/cam_helper.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp index 1b2d6eec..eaf73019 100644 --- a/src/ipa/raspberrypi/cam_helper.hpp +++ b/src/ipa/raspberrypi/cam_helper.hpp @@ -16,8 +16,8 @@ namespace RPiController { // The CamHelper class provides a number of facilities that anyone trying -// trying to drive a camera will need to know, but which are not provided by -// by the standard driver framework. Specifically, it provides: +// to drive a camera will need to know, but which are not provided by the +// standard driver framework. Specifically, it provides: // // A "CameraMode" structure to describe extra information about the chosen // mode of the driver. For example, how it is cropped from the full sensor From patchwork Wed Apr 14 18:02:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Fricke X-Patchwork-Id: 11932 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 69C9DBD1F6 for ; Wed, 14 Apr 2021 18:03:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2C6C96880B; Wed, 14 Apr 2021 20:03:43 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=posteo.net header.i=@posteo.net header.b="hpFMbaaU"; dkim-atps=neutral Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0666068803 for ; Wed, 14 Apr 2021 20:03:41 +0200 (CEST) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 542AE1A022C for ; Wed, 14 Apr 2021 20:03:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618423420; bh=pv+iyQ4XCR987H4tGVkUiLJ+zYVmqb8d9delcy7rPnA=; h=From:To:Cc:Subject:Date:From; b=hpFMbaaUQMZLmvrrRV8VEE/WyQs+TQxVG1ISIzbYms92+BjwosoA+uumMmYGHDW0+ uvM/ZHEantTbqdRPAZO/AzESfbi7/00etJzpwhCnTxQD1eU5ltCa7EcMHmUmiU5FWu 9OpESo7nP7eLlyfUVdwMHLHKIc7ZtDRypupznb7CmHshB7r/8XS4EG1247XnVvOtF6 ORPZXddO6+SxApqQMdupaSLYfyjU2fvht2mTJ3h0s+suAyhGudK2pKz2qCyH76+qLN GsMELt2sg2OW7huLGKYCXkUZcpnblXlB3Ywp1dursHBrymxZoU2aQ6YbzJS7Koopua OOFySMvImbfRQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FL9MH3fgJz6tmS; Wed, 14 Apr 2021 20:03:39 +0200 (CEST) From: Sebastian Fricke To: libcamera-devel@lists.libcamera.org Date: Wed, 14 Apr 2021 20:02:58 +0200 Message-Id: <20210414180256.10724-2-sebastian.fricke@posteo.net> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210414180256.10724-1-sebastian.fricke@posteo.net> References: <20210414180256.10724-1-sebastian.fricke@posteo.net> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/2] ipa: cam_helper.hpp: Correct a wrong choice of term X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Sensors provide embedded buffers and not metadata buffers, replace the incorrect term with the correct one. Signed-off-by: Sebastian Fricke Reviewed-by: David Plowman --- src/ipa/raspberrypi/cam_helper.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp index eaf73019..2ab3d49f 100644 --- a/src/ipa/raspberrypi/cam_helper.hpp +++ b/src/ipa/raspberrypi/cam_helper.hpp @@ -35,7 +35,7 @@ namespace RPiController { // // A method to query if the sensor outputs embedded data that can be parsed. // -// A parser to parse the metadata buffers provided by some sensors (for +// A parser to parse the embedded buffers provided by some sensors (for // example, the imx219 does; the ov5647 doesn't). This allows us to know for // sure the exposure and gain of the frame we're looking at. CamHelper // provides methods for converting analogue gains to and from the sensor's