| Message ID | 20201012095343.14283-1-andrey.konovalov@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Andrey, On 12/10/2020 10:53, Andrey Konovalov wrote: > qcom-camss driver supports MIPI CSI2 receivers on APQ8016 and APQ8096 > Application processors from Qualcomm, which are used on e.g. DragonBoard > 410c and DragonBoard 820c dev boards respectively. > > The simple pipeline handler provides basic support for these devices. Excellent, an entire platform support addition with one line :-) I'm dreaming that it could be automatic to have the simple pipeline handler 'identify' targets it could support (as long as it was the last pipeline handler to run) but I think that's possibly more headaches than we want right now ;-) So single line additions of platforms known to work is good enough for me ;-) > Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/simple/simple.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > index 769fe699..15e733cd 100644 > --- a/src/libcamera/pipeline/simple/simple.cpp > +++ b/src/libcamera/pipeline/simple/simple.cpp > @@ -50,6 +50,7 @@ namespace { > static const SimplePipelineInfo supportedDevices[] = { > { "imx7-csi", "pxp" }, > { "sun6i-csi", nullptr }, > + { "qcom-camss", nullptr }, > }; > > } /* namespace */ >
Hi Andrey, Thank you for the patch. On Mon, Oct 12, 2020 at 11:51:53AM +0100, Kieran Bingham wrote: > On 12/10/2020 10:53, Andrey Konovalov wrote: > > qcom-camss driver supports MIPI CSI2 receivers on APQ8016 and APQ8096 > > Application processors from Qualcomm, which are used on e.g. DragonBoard > > 410c and DragonBoard 820c dev boards respectively. > > > > The simple pipeline handler provides basic support for these devices. > > Excellent, an entire platform support addition with one line :-) > > I'm dreaming that it could be automatic to have the simple pipeline > handler 'identify' targets it could support (as long as it was the last > pipeline handler to run) but I think that's possibly more headaches than > we want right now ;-) > > So single line additions of platforms known to work is good enough for > me ;-) > > > Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org> > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > --- > > src/libcamera/pipeline/simple/simple.cpp | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > > index 769fe699..15e733cd 100644 > > --- a/src/libcamera/pipeline/simple/simple.cpp > > +++ b/src/libcamera/pipeline/simple/simple.cpp > > @@ -50,6 +50,7 @@ namespace { > > static const SimplePipelineInfo supportedDevices[] = { > > { "imx7-csi", "pxp" }, > > { "sun6i-csi", nullptr }, > > + { "qcom-camss", nullptr }, Let's keep these alphabetically sorted. With that fixed, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I'll apply this change when pushing. > > }; > > > > } /* namespace */
diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 769fe699..15e733cd 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -50,6 +50,7 @@ namespace { static const SimplePipelineInfo supportedDevices[] = { { "imx7-csi", "pxp" }, { "sun6i-csi", nullptr }, + { "qcom-camss", nullptr }, }; } /* namespace */
qcom-camss driver supports MIPI CSI2 receivers on APQ8016 and APQ8096 Application processors from Qualcomm, which are used on e.g. DragonBoard 410c and DragonBoard 820c dev boards respectively. The simple pipeline handler provides basic support for these devices. Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org> --- src/libcamera/pipeline/simple/simple.cpp | 1 + 1 file changed, 1 insertion(+)