[libcamera-devel,0/5] libcamera: camera data: Address review comments
mbox series

Message ID 20190125170400.24821-1-jacopo@jmondi.org
Headers show
Series
  • libcamera: camera data: Address review comments
Related show

Message

Jacopo Mondi Jan. 25, 2019, 5:03 p.m. UTC 
Address review comments with follow up patches.

Jacopo Mondi (5):
  libcamera: pipeline: Fix operator= declaration
  libcamera: pipeline: Remove duplicated include
  libcamera: pipeline: Rework class destructor
  libcamera: pipeline: Misc comments update
  libcamera: pipeline: Refuse to substitute camera data

 src/libcamera/include/pipeline_handler.h |  4 +-
 src/libcamera/pipeline_handler.cpp       | 47 +++++++++++-------------
 2 files changed, 24 insertions(+), 27 deletions(-)

--
2.20.1

Comments

Laurent Pinchart Jan. 25, 2019, 5:13 p.m. UTC | #1 
Hi Jacopo,

Thank you for the patches.

On Fri, Jan 25, 2019 at 06:03:55PM +0100, Jacopo Mondi wrote:
> Address review comments with follow up patches.
> 
> Jacopo Mondi (5):
>   libcamera: pipeline: Fix operator= declaration
>   libcamera: pipeline: Remove duplicated include
>   libcamera: pipeline: Rework class destructor
>   libcamera: pipeline: Misc comments update

For 1-4,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>   libcamera: pipeline: Refuse to substitute camera data
> 
>  src/libcamera/include/pipeline_handler.h |  4 +-
>  src/libcamera/pipeline_handler.cpp       | 47 +++++++++++-------------
>  2 files changed, 24 insertions(+), 27 deletions(-)
>