[libcamera-devel,1/5] libcamera: pipeline: Fix operator= declaration

Message ID 20190125170400.24821-2-jacopo@jmondi.org
State Accepted
Headers show
Series
  • libcamera: camera data: Address review comments
Related show

Commit Message

Jacopo Mondi Jan. 25, 2019, 5:03 p.m. UTC
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/include/pipeline_handler.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Niklas Söderlund Jan. 25, 2019, 10:41 p.m. UTC | #1
Hi Jacopo,

Thanks for your work.

On 2019-01-25 18:03:56 +0100, Jacopo Mondi wrote:
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/include/pipeline_handler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
> index 0db8421..ca77a40 100644
> --- a/src/libcamera/include/pipeline_handler.h
> +++ b/src/libcamera/include/pipeline_handler.h
> @@ -29,7 +29,7 @@ protected:
>  
>  private:
>  	CameraData(const CameraData &) = delete;
> -	void operator=(const CameraData &) = delete;
> +	CameraData &operator=(const CameraData &) = delete;
>  };
>  
>  class PipelineHandler : public std::enable_shared_from_this<PipelineHandler>
> -- 
> 2.20.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
index 0db8421..ca77a40 100644
--- a/src/libcamera/include/pipeline_handler.h
+++ b/src/libcamera/include/pipeline_handler.h
@@ -29,7 +29,7 @@  protected:
 
 private:
 	CameraData(const CameraData &) = delete;
-	void operator=(const CameraData &) = delete;
+	CameraData &operator=(const CameraData &) = delete;
 };
 
 class PipelineHandler : public std::enable_shared_from_this<PipelineHandler>