[libcamera-devel,v3,0/6] {cam, qcam}: Unify stream option parsing
mbox series

Message ID 20200501023432.90032-1-niklas.soderlund@ragnatech.se
Headers show
Series
  • {cam, qcam}: Unify stream option parsing
Related show

Message

Niklas Söderlund May 1, 2020, 2:34 a.m. UTC 
Hi,

Prepare for allowing multiple streams in qcam by unifying the cam and
qcam command line options parsing for stream options. With this RAW
capture support can be added to qcam without first redesigning the whole
GUI to allow for individual stream configuration.

Also having the same options for cam and qcam to configure streams is a
good idea. As this series reveals some features where enabled in cam but
not in qcam.

Niklas Söderlund (6):
  cam: options: Make KeyValueParser::parse() virtual
  cam: options: Add public method to invalidate options
  cam: Add helper class to parse stream configuration
  cam: Make use of StreamKeyValueParser
  qcam: Make use of StreamKeyValueParser
  qcam: Check that camera can generate configuration from roles

 src/cam/main.cpp           |  68 ++-----------------
 src/cam/meson.build        |   1 +
 src/cam/options.cpp        |   6 ++
 src/cam/options.h          |   6 +-
 src/cam/stream_options.cpp | 129 +++++++++++++++++++++++++++++++++++++
 src/cam/stream_options.h   |  32 +++++++++
 src/qcam/main.cpp          |  13 ++--
 src/qcam/main_window.cpp   |  41 +++++++-----
 src/qcam/main_window.h     |   4 +-
 src/qcam/meson.build       |   1 +
 10 files changed, 212 insertions(+), 89 deletions(-)
 create mode 100644 src/cam/stream_options.cpp
 create mode 100644 src/cam/stream_options.h

Comments

Niklas Söderlund May 1, 2020, 10:59 a.m. UTC | #1 
Hi,

I have now pushed this to master.

On 2020-05-01 04:34:26 +0200, Niklas Söderlund wrote:
> Hi,
> 
> Prepare for allowing multiple streams in qcam by unifying the cam and
> qcam command line options parsing for stream options. With this RAW
> capture support can be added to qcam without first redesigning the whole
> GUI to allow for individual stream configuration.
> 
> Also having the same options for cam and qcam to configure streams is a
> good idea. As this series reveals some features where enabled in cam but
> not in qcam.
> 
> Niklas Söderlund (6):
>   cam: options: Make KeyValueParser::parse() virtual
>   cam: options: Add public method to invalidate options
>   cam: Add helper class to parse stream configuration
>   cam: Make use of StreamKeyValueParser
>   qcam: Make use of StreamKeyValueParser
>   qcam: Check that camera can generate configuration from roles
> 
>  src/cam/main.cpp           |  68 ++-----------------
>  src/cam/meson.build        |   1 +
>  src/cam/options.cpp        |   6 ++
>  src/cam/options.h          |   6 +-
>  src/cam/stream_options.cpp | 129 +++++++++++++++++++++++++++++++++++++
>  src/cam/stream_options.h   |  32 +++++++++
>  src/qcam/main.cpp          |  13 ++--
>  src/qcam/main_window.cpp   |  41 +++++++-----
>  src/qcam/main_window.h     |   4 +-
>  src/qcam/meson.build       |   1 +
>  10 files changed, 212 insertions(+), 89 deletions(-)
>  create mode 100644 src/cam/stream_options.cpp
>  create mode 100644 src/cam/stream_options.h
> 
> -- 
> 2.26.2
>