From patchwork Fri May 1 02:34:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 3643 Return-Path: Received: from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net [195.74.38.229]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2985A6148D for ; Fri, 1 May 2020 04:34:43 +0200 (CEST) X-Halon-ID: 4adc98aa-8b54-11ea-89d0-0050569116f7 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de [79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA id 4adc98aa-8b54-11ea-89d0-0050569116f7; Fri, 01 May 2020 04:34:40 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Fri, 1 May 2020 04:34:26 +0200 Message-Id: <20200501023432.90032-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/6] {cam, qcam}: Unify stream option parsing X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2020 02:34:43 -0000 Hi, Prepare for allowing multiple streams in qcam by unifying the cam and qcam command line options parsing for stream options. With this RAW capture support can be added to qcam without first redesigning the whole GUI to allow for individual stream configuration. Also having the same options for cam and qcam to configure streams is a good idea. As this series reveals some features where enabled in cam but not in qcam. Niklas Söderlund (6): cam: options: Make KeyValueParser::parse() virtual cam: options: Add public method to invalidate options cam: Add helper class to parse stream configuration cam: Make use of StreamKeyValueParser qcam: Make use of StreamKeyValueParser qcam: Check that camera can generate configuration from roles src/cam/main.cpp | 68 ++----------------- src/cam/meson.build | 1 + src/cam/options.cpp | 6 ++ src/cam/options.h | 6 +- src/cam/stream_options.cpp | 129 +++++++++++++++++++++++++++++++++++++ src/cam/stream_options.h | 32 +++++++++ src/qcam/main.cpp | 13 ++-- src/qcam/main_window.cpp | 41 +++++++----- src/qcam/main_window.h | 4 +- src/qcam/meson.build | 1 + 10 files changed, 212 insertions(+), 89 deletions(-) create mode 100644 src/cam/stream_options.cpp create mode 100644 src/cam/stream_options.h