[libcamera-devel,v4,0/5] libcamera: determine IPA_PROXY_PATH at runtime
mbox series

Message ID 20200318152427.13126-1-kgupta@es.iitr.ac.in
Headers show
Series
  • libcamera: determine IPA_PROXY_PATH at runtime
Related show

Message

Kaaira Gupta March 18, 2020, 3:24 p.m. UTC 
This is a series of patches to determine IPA_PROXY_PATH at runtime,
removing hard-coded LIBCAMERA_IPA_PROXY_PATH from test.cpp and making
isLibcamerainstalled() and libcameraPath() utils' functions.

Changes since v3:
Renumbered the patches to account for the squashing patch 3 and 5 in one
patch.

Patch 1: No Changes.
Patch 2: No changes.
Patch 3: Squashed patch 5 with this patch. Rearranged headers
alphabetically and used imperative in \brief statements. Changed
Libcamera to libcamera and wrapped lines at 80 characters.
Patch 4: Re-wrote the commit message as per reviews, changed 'proxy' to
'proxy workers', corrected the proxy workers' path, wrapped lines at
80 characters, and added a return std::string() while checking the
condition !libcameraInstalled.
Patch 5: No changes (previously patch 6).

Changes since v2:
Patch 1: No changes.
Patch 2: No changes.
Patch 3: Declared functions in utils.h and declared _DYNAMIC extern
outside namespace libcamera
Patch 4: No changes.
Patch 5: No changes.
Patch 6: No changes.

Changes since v1:
Renumbered the patches to account for two additional patches as
described below.

Patch 1: Fixed whitespace problems.
Patch 2: Fixed whitespace problems.
Patch 3: NEW PATCH: Adds isLibcamerainstalled() and libcameraPath()
as global functions in utils module.
Patch 4: Earlier patch 3: fixed styling issues and used helper functions
of utils instead of defining own functions.
Patch 5: NEW PATCH: Replace isLibcamerainstalled() and libcameraPath()
by helper functions defined in utils in ipa_manager
Patch 6: Earlier patch 4: Fixed odd tab in comment description.

Kaaira Gupta (5):
  libcamera: ipa_proxy: use utils::split()
  libcamera: ipa_proxy: rearrange proxies precedence
  libcamera: utils: Move libcamera build path lookup to utis
  libcamera: ipa_proxy: search for proxy in build tree
  tests: remove IPA_PROXY_PATH environment variable

 src/libcamera/include/utils.h |  4 +++
 src/libcamera/ipa_manager.cpp | 36 ++-----------------------
 src/libcamera/ipa_proxy.cpp   | 45 ++++++++++++++++++++++----------
 src/libcamera/utils.cpp       | 49 +++++++++++++++++++++++++++++++++++
 test/libtest/test.cpp         |  4 ---
 5 files changed, 86 insertions(+), 52 deletions(-)

Comments

Kieran Bingham March 18, 2020, 4:33 p.m. UTC | #1 
Hi Kaaira,

Thank you for your efforts on this topic.
I've merged this series.

Please record it in your contribution lists.

--
Regards

Kieran


On 18/03/2020 15:24, Kaaira Gupta wrote:
> This is a series of patches to determine IPA_PROXY_PATH at runtime,
> removing hard-coded LIBCAMERA_IPA_PROXY_PATH from test.cpp and making
> isLibcamerainstalled() and libcameraPath() utils' functions.
> 
> Changes since v3:
> Renumbered the patches to account for the squashing patch 3 and 5 in one
> patch.
> 
> Patch 1: No Changes.
> Patch 2: No changes.
> Patch 3: Squashed patch 5 with this patch. Rearranged headers
> alphabetically and used imperative in \brief statements. Changed
> Libcamera to libcamera and wrapped lines at 80 characters.
> Patch 4: Re-wrote the commit message as per reviews, changed 'proxy' to
> 'proxy workers', corrected the proxy workers' path, wrapped lines at
> 80 characters, and added a return std::string() while checking the
> condition !libcameraInstalled.
> Patch 5: No changes (previously patch 6).
> 
> Changes since v2:
> Patch 1: No changes.
> Patch 2: No changes.
> Patch 3: Declared functions in utils.h and declared _DYNAMIC extern
> outside namespace libcamera
> Patch 4: No changes.
> Patch 5: No changes.
> Patch 6: No changes.
> 
> Changes since v1:
> Renumbered the patches to account for two additional patches as
> described below.
> 
> Patch 1: Fixed whitespace problems.
> Patch 2: Fixed whitespace problems.
> Patch 3: NEW PATCH: Adds isLibcamerainstalled() and libcameraPath()
> as global functions in utils module.
> Patch 4: Earlier patch 3: fixed styling issues and used helper functions
> of utils instead of defining own functions.
> Patch 5: NEW PATCH: Replace isLibcamerainstalled() and libcameraPath()
> by helper functions defined in utils in ipa_manager
> Patch 6: Earlier patch 4: Fixed odd tab in comment description.
> 
> Kaaira Gupta (5):
>   libcamera: ipa_proxy: use utils::split()
>   libcamera: ipa_proxy: rearrange proxies precedence
>   libcamera: utils: Move libcamera build path lookup to utis
>   libcamera: ipa_proxy: search for proxy in build tree
>   tests: remove IPA_PROXY_PATH environment variable
> 
>  src/libcamera/include/utils.h |  4 +++
>  src/libcamera/ipa_manager.cpp | 36 ++-----------------------
>  src/libcamera/ipa_proxy.cpp   | 45 ++++++++++++++++++++++----------
>  src/libcamera/utils.cpp       | 49 +++++++++++++++++++++++++++++++++++
>  test/libtest/test.cpp         |  4 ---
>  5 files changed, 86 insertions(+), 52 deletions(-)
>