| Message ID | 20261028-kbingham-duplicate-id-v2-0-e82448998d88@ideasonboard.com |
|---|---|
| Headers | show
Return-Path: <libcamera-devel-bounces@lists.libcamera.org> X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 83063C324C for <parsemail@patchwork.libcamera.org>; Wed, 28 Oct 2026 12:02:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 543446907B; Wed, 28 Oct 2026 13:02:28 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BxqFo7nx"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A32E068F8B for <libcamera-devel@lists.libcamera.org>; Wed, 28 Oct 2026 13:02:26 +0100 (CET) Received: from ping.linuxembedded.co.uk (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A7F274F1; Wed, 28 Oct 2026 13:00:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1793188813; bh=ThQcSIJ+BNJj/7eZYVu+W1sBMdsJ5VDm1GekMYdaxaI=; h=From:Subject:Date:To:Cc:From; b=BxqFo7nxpTCjZgIb5jsVlSsJbR21e5kPlz+zkzARTdDzIYPSwPuHmTRYr6oauLK/8 epl9vLr1jk6xPVt1aIRlcBxooxo7egS0339ib3hVOi6/OLWgoAb8PLSPCGefLk3Ikx 057C4r2L+fM2LvjRRlMXYyRNoyFu7OM6ooRFZh+g= From: Kieran Bingham <kieran.bingham@ideasonboard.com> Subject: [PATCH v2 0/2] libcamera: camera_manager: Non-fatal duplicate id detection Date: Wed, 28 Oct 2026 12:02:17 +0000 Message-Id: <20261028-kbingham-duplicate-id-v2-0-e82448998d88@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAEnk4WoC/x2MQQqAIBAAvxJ7TjArkb4SHUy3XCoLrQiiv2cdB 2bmhoiBMEKT3RDwpEirTyDyDIzTfkRGNjEILmTBhWJTT350emH22GYyev8MZowqa7RcVVJDare AA13/t+2e5wU3yJ/zZwAAAA== X-Change-ID: 20261028-kbingham-duplicate-id-cc835ed0846a To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab?= =?utf-8?b?w6FzIFDFkWN6ZQ==?= <barnabas.pocze@ideasonboard.com> X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1793188945; l=1284; i=kieran.bingham@ideasonboard.com; s=20260207; h=from:subject:message-id; bh=ThQcSIJ+BNJj/7eZYVu+W1sBMdsJ5VDm1GekMYdaxaI=; b=vqMJfaOanDGTDDI6f/iUp0W5Kl4kd+kT9Ue825SphxT5Kb5tV6H4ZHYyzliTqGSHaUTpX4Wrw tS0K5thX3OpCm7V3JotD9pCcHFEO2enW+Sz00vds2BtmXsOM2Of1xys X-Developer-Key: i=kieran.bingham@ideasonboard.com; a=ed25519; pk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY= X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org> |
| Series |
|
| Related |
show
|
We face bug reports from users [0] where real life situations will currently create a duplicate camera id, and we do not currently have a good solution to identify a unique path for these devices. [0] https://gitlab.freedesktop.org/camera/libcamera/-/work_items/303 We could look later to see if we create a sequential number to append to these devices but for the moment lets make sure we don't crash users systems with an assert. Following a request from v1, I've now added a unit test which constucts a test pipeline handler that can be instantiated multiple times to validate the same code paths internally. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- Kieran Bingham (2): libcamera: camera_manager: Non-fatal duplicate id detection test: pipeline: Add a duplicate camera construction test src/libcamera/camera_manager.cpp | 2 +- test/meson.build | 1 + test/pipeline/duplicate_camera_id.cpp | 202 ++++++++++++++++++++++++++++++++++ test/pipeline/meson.build | 14 +++ 4 files changed, 218 insertions(+), 1 deletion(-) --- base-commit: 182307a772ebebf173ee84911906da707718485f change-id: 20261028-kbingham-duplicate-id-cc835ed0846a Best regards,