[v2,0/6] Eliminating startup frames
mbox series

Message ID 20250522075244.1198110-1-naush@raspberrypi.com
Headers show
Series
  • Eliminating startup frames
Related show

Message

Naushir Patuck May 22, 2025, 7:48 a.m. UTC 
Hi,

Minor changes in version 2:

- In patch 1, wording changes for the FrameMetadata::Status description.
- In patch 3, reflow some changes to look neater, and fix a bug when
  decrementing the invalidFrameCount_ and startupFrameCount_ together.

Thanks,
Naush

Naushir Patuck (6):
  libcamera: framebuffer: Add FrameMetadata::Status::FrameStartup
  ipa: rpi: Replace dropFrameCount in the IPA -> PH interface
  pipeline: ipa: rpi: Split RPiCameraData::dropFrameCount_
  pipeline: rpi: Remove disable_startup_frame_drops config option
  pipeline: rpi: Remove ispOutputCount_ and ispOutputTotal_
  ipa: rpi: Rename dropFrameCount_ to startupCount_

 include/libcamera/framebuffer.h               |   1 +
 include/libcamera/ipa/raspberrypi.mojom       |   3 +-
 src/ipa/rpi/common/ipa_base.cpp               |  20 ++--
 src/ipa/rpi/common/ipa_base.h                 |   4 +-
 src/libcamera/framebuffer.cpp                 |  13 ++-
 .../pipeline/rpi/common/pipeline_base.cpp     | 105 +++++++-----------
 .../pipeline/rpi/common/pipeline_base.h       |  14 +--
 .../pipeline/rpi/pisp/data/example.yaml       |   5 -
 src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  12 --
 .../pipeline/rpi/vc4/data/example.yaml        |   5 -
 src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  15 ---
 11 files changed, 72 insertions(+), 125 deletions(-)

Comments

Naushir Patuck June 2, 2025, 7:37 a.m. UTC | #1 
Hi all,

Any further thoughts on this series?

Thanks!
Naush


On Thu, 22 May 2025 at 08:52, Naushir Patuck <naush@raspberrypi.com> wrote:

> Hi,
>
> Minor changes in version 2:
>
> - In patch 1, wording changes for the FrameMetadata::Status description.
> - In patch 3, reflow some changes to look neater, and fix a bug when
>   decrementing the invalidFrameCount_ and startupFrameCount_ together.
>
> Thanks,
> Naush
>
> Naushir Patuck (6):
>   libcamera: framebuffer: Add FrameMetadata::Status::FrameStartup
>   ipa: rpi: Replace dropFrameCount in the IPA -> PH interface
>   pipeline: ipa: rpi: Split RPiCameraData::dropFrameCount_
>   pipeline: rpi: Remove disable_startup_frame_drops config option
>   pipeline: rpi: Remove ispOutputCount_ and ispOutputTotal_
>   ipa: rpi: Rename dropFrameCount_ to startupCount_
>
>  include/libcamera/framebuffer.h               |   1 +
>  include/libcamera/ipa/raspberrypi.mojom       |   3 +-
>  src/ipa/rpi/common/ipa_base.cpp               |  20 ++--
>  src/ipa/rpi/common/ipa_base.h                 |   4 +-
>  src/libcamera/framebuffer.cpp                 |  13 ++-
>  .../pipeline/rpi/common/pipeline_base.cpp     | 105 +++++++-----------
>  .../pipeline/rpi/common/pipeline_base.h       |  14 +--
>  .../pipeline/rpi/pisp/data/example.yaml       |   5 -
>  src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  12 --
>  .../pipeline/rpi/vc4/data/example.yaml        |   5 -
>  src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  15 ---
>  11 files changed, 72 insertions(+), 125 deletions(-)
>
> --
> 2.43.0
>
>