[v7,0/5] libcamera: start frame events changes
mbox series

Message ID 20250403074551.263496-1-stanislaw.gruszka@linux.intel.com
Headers show
Series
  • libcamera: start frame events changes
Related show

Message

Stanislaw Gruszka April 3, 2025, 7:45 a.m. UTC 
v6 -> v7:
 - document disabling event side effect
 - add Stefan and Kieran R-b tags

v5 -> v6:
 - remove changelog paragraph not applicable any longer in patch1
 - use new clang-format formatting in patch1
 - split patches differently
 - use Laurent changelog wording
 - add various comments in the code
 - use '' in log when printing emitter name

v4 -> v5:
 - split patch2 into 3 separte patches
 - drop frameStartEnabled(), return error from start
 - use for (const Entity &entity : entities_) insted of iterator
 - reset delayed controls before enabling events

v3 -> v4:
 - constify frameStartEnabled()
 - make supportsFrameStartEvent() more readable
 - rename eventEmitter to startFrameEmitter
 - update patch2 changelog to make it more clear

v2 -> v3:
 - add helpers for v4l2_device
 - initialize eventEmitter_ in init(), when no proper device is found
   use nullptr (this fix crash seen by Kieran as eventEmitetter was
	 not nullptr in v2)

v1 -> v2:
 - make eventEmitter_ subdevice part of SimpleCameraData
 - add debug log when found event emitter device
 - nullify eventEmitter_ on stop
 - remove direct sensor_->setControls()
 - add delayedCtrls_->reset() on start


Laurent Pinchart (1):
  pipeline: simple: Create DelayedControls instance once only

Stanislaw Gruszka (4):
  libcamera: v4l2_device: add frame start event helpers
  pipeline: simple: Connect/disconnect frameStart signal at start/stop
    time
  pipeline: simple: Enable frame start events
  pipeline: simple: Reset delayedCtrls at start

 include/libcamera/internal/v4l2_device.h |  1 +
 src/libcamera/pipeline/simple/simple.cpp | 66 +++++++++++++++++++-----
 src/libcamera/v4l2_device.cpp            | 22 ++++++++
 3 files changed, 76 insertions(+), 13 deletions(-)

--
2.43.0