[v5,0/3] Clean up pending requests on stop in software ISP
mbox series

Message ID 20241021133718.894374-1-mzamazal@redhat.com
Headers show
Series
  • Clean up pending requests on stop in software ISP
Related show

Message

Milan Zamazal Oct. 21, 2024, 1:37 p.m. UTC 
Fix for the bug #234 where software ISP may not clean up some pending
buffers in stopDevice.

Changes in v5:
- Use a struct instead of std::pair in conversionQueue_.

Changes in v4:
- Request explicitly tracked as suggested by Laurent.

Changes in v3:
- Split to two patches according to different code areas affected.
- Added a check for the request status to prevent canceling a request
  multiple times.
- Calling conversionBuffers_.clear() after the cleanup, to be safer.

Changes in v2:
- The request is additionally canceled.
- New helper method PipelineHandler::cancelRequest() introduced.

Milan Zamazal (3):
  libcamera: pipeline_handler: Provide cancelRequest
  libcamera: simple: Track requests in conversionQueue_
  libcamera: software_isp: Clean up pending requests on stop

 include/libcamera/internal/pipeline_handler.h |  1 +
 src/libcamera/pipeline/simple/simple.cpp      | 36 ++++++++++++-------
 src/libcamera/pipeline_handler.cpp            | 23 ++++++++----
 3 files changed, 40 insertions(+), 20 deletions(-)

Comments

Stanislaw Gruszka Oct. 21, 2024, 3:20 p.m. UTC | #1 
On Mon, Oct 21, 2024 at 03:37:15PM +0200, Milan Zamazal wrote:
> Fix for the bug #234 where software ISP may not clean up some pending
> buffers in stopDevice.

I also had crash from #234 when disabling qcam. This series make
it gone. 

Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Milan Zamazal Nov. 6, 2024, 8:20 p.m. UTC | #2 
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> writes:

> On Mon, Oct 21, 2024 at 03:37:15PM +0200, Milan Zamazal wrote:
>> Fix for the bug #234 where software ISP may not clean up some pending
>> buffers in stopDevice.
>
> I also had crash from #234 when disabling qcam. This series make
> it gone. 
>
> Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

Hi Stanislaw,

thank you for testing.  With v6, I believe it can get merged soon.

Regards,
Milan