[RFC,0/4] libcamera: Implement YamlEmitter
mbox series

Message ID 20241014095937.24924-1-jacopo.mondi@ideasonboard.com
Headers show
Series
  • libcamera: Implement YamlEmitter
Related show

Message

Jacopo Mondi Oct. 14, 2024, 9:59 a.m. UTC 
This series collects Paul's
[PATCH 0/2] libcamera: Add support for dumping capture script

and implements a YamlEmitter class on top, replacing the usage of raw
output streams with the YamlEmitter class.

RFC mostly to collect opinions on the interface.
Documentation mostly to be done, rough edges here and there :)

Jacopo Mondi (2):
  libcamera: Implement YamlEmitter
  libcamera: pipeline_handler: Use YamlEmitter

Paul Elder (2):
  pipeline: Add support for dumping capture script and metadata
  apps: cam: Add support for loading configuration from capture script

 include/libcamera/internal/camera.h           |   3 +
 include/libcamera/internal/meson.build        |   1 +
 include/libcamera/internal/pipeline_handler.h |  23 +
 include/libcamera/internal/yaml_emitter.h     | 172 +++++++
 src/apps/cam/camera_session.cpp               |  22 +-
 src/apps/cam/capture_script.cpp               | 164 +++++++
 src/apps/cam/capture_script.h                 |   8 +
 src/libcamera/camera.cpp                      |  13 +
 src/libcamera/meson.build                     |   1 +
 src/libcamera/pipeline_handler.cpp            |  87 ++++
 src/libcamera/yaml_emitter.cpp                | 427 ++++++++++++++++++
 11 files changed, 911 insertions(+), 10 deletions(-)
 create mode 100644 include/libcamera/internal/yaml_emitter.h
 create mode 100644 src/libcamera/yaml_emitter.cpp

--
2.46.2

Comments

Laurent Pinchart Oct. 15, 2024, 10:21 a.m. UTC | #1 
Hi Jacopo,

On Mon, Oct 14, 2024 at 11:59:32AM +0200, Jacopo Mondi wrote:
> This series collects Paul's
> [PATCH 0/2] libcamera: Add support for dumping capture script

Paul has sent a v2, and has received review comments. I suppose you
don't plan to address them. Paul, will you send a v3 for Jacopo to
rebase this series on ?

> and implements a YamlEmitter class on top, replacing the usage of raw
> output streams with the YamlEmitter class.
> 
> RFC mostly to collect opinions on the interface.
> Documentation mostly to be done, rough edges here and there :)
> 
> Jacopo Mondi (2):
>   libcamera: Implement YamlEmitter
>   libcamera: pipeline_handler: Use YamlEmitter
> 
> Paul Elder (2):
>   pipeline: Add support for dumping capture script and metadata
>   apps: cam: Add support for loading configuration from capture script
> 
>  include/libcamera/internal/camera.h           |   3 +
>  include/libcamera/internal/meson.build        |   1 +
>  include/libcamera/internal/pipeline_handler.h |  23 +
>  include/libcamera/internal/yaml_emitter.h     | 172 +++++++
>  src/apps/cam/camera_session.cpp               |  22 +-
>  src/apps/cam/capture_script.cpp               | 164 +++++++
>  src/apps/cam/capture_script.h                 |   8 +
>  src/libcamera/camera.cpp                      |  13 +
>  src/libcamera/meson.build                     |   1 +
>  src/libcamera/pipeline_handler.cpp            |  87 ++++
>  src/libcamera/yaml_emitter.cpp                | 427 ++++++++++++++++++
>  11 files changed, 911 insertions(+), 10 deletions(-)
>  create mode 100644 include/libcamera/internal/yaml_emitter.h
>  create mode 100644 src/libcamera/yaml_emitter.cpp