[libcamera-devel,v2,00/10] Raspberry Pi: Platform configuration and buffer allocation improvements
mbox series

Message ID 20221129134534.2933-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi: Platform configuration and buffer allocation improvements
Related show

Message

Naushir Patuck Nov. 29, 2022, 1:45 p.m. UTC 
Hi,

Version 2 of this series addresses all of David's suggestions/fixes.  The only
other changes is in patch 1, we explicitly provide a subdir as well as a filename
into PipelineHandler::configurationFile().

Thanks,
Naush

Naushir Patuck (10):
  libcamera: pipeline: Add a platform configuration file helper
  pipeline: raspberrypi: Add a pipeline config structure
  pipeline: raspberrypi: Split out ISP Output0 buffer allocation
  pipeline: raspberrypi: Read config parameters from a file
  pipeline: raspberrypi: Disable StreamOn for ISP Output0/1 when
    dropping frames
  pipeline: raspberrypi: Reorder startup drop frame initialisation
  pipeline: raspberrypi: Add a parameter to disable startup drop frames
  pipeline: raspberrypi: Allow pipeline handler to always use the newest
    frame
  pipeline: raspberrypi: Add minimal memory usage config file
  pipeline: raspberrypi: Add libcamera-apps and picamera2 config file

 include/libcamera/internal/pipeline_handler.h |   3 +
 .../pipeline/raspberrypi/data/default.json    |  28 ++
 .../pipeline/raspberrypi/data/meson.build     |  10 +
 .../raspberrypi/data/minimal_mem.json         |  28 ++
 .../pipeline/raspberrypi/data/rpi_apps.json   |  28 ++
 .../pipeline/raspberrypi/meson.build          |   2 +
 .../pipeline/raspberrypi/raspberrypi.cpp      | 239 +++++++++++++++---
 src/libcamera/pipeline_handler.cpp            |  60 +++++
 8 files changed, 367 insertions(+), 31 deletions(-)
 create mode 100644 src/libcamera/pipeline/raspberrypi/data/default.json
 create mode 100644 src/libcamera/pipeline/raspberrypi/data/meson.build
 create mode 100644 src/libcamera/pipeline/raspberrypi/data/minimal_mem.json
 create mode 100644 src/libcamera/pipeline/raspberrypi/data/rpi_apps.json

Comments

Laurent Pinchart Dec. 2, 2022, 9:43 p.m. UTC | #1 
Hi Naush,

Thank you for the patches.

CC'ing Han-Lin.

Han-Lin has submitted a patch series that introduces a pipeline
configuration file for the IPU3 ([1]). As this series does something
similar for the Raspberry Pi pipeline handler, could I ask you both for
cross-reviews of the two series ? I would like to avoid having two
separate and very different implementations for the common parts.

[1] https://patchwork.libcamera.org/project/libcamera/list/?series=2923

On Tue, Nov 29, 2022 at 01:45:24PM +0000, Naushir Patuck via libcamera-devel wrote:
> Hi,
> 
> Version 2 of this series addresses all of David's suggestions/fixes.  The only
> other changes is in patch 1, we explicitly provide a subdir as well as a filename
> into PipelineHandler::configurationFile().
> 
> Thanks,
> Naush
> 
> Naushir Patuck (10):
>   libcamera: pipeline: Add a platform configuration file helper
>   pipeline: raspberrypi: Add a pipeline config structure
>   pipeline: raspberrypi: Split out ISP Output0 buffer allocation
>   pipeline: raspberrypi: Read config parameters from a file
>   pipeline: raspberrypi: Disable StreamOn for ISP Output0/1 when
>     dropping frames
>   pipeline: raspberrypi: Reorder startup drop frame initialisation
>   pipeline: raspberrypi: Add a parameter to disable startup drop frames
>   pipeline: raspberrypi: Allow pipeline handler to always use the newest
>     frame
>   pipeline: raspberrypi: Add minimal memory usage config file
>   pipeline: raspberrypi: Add libcamera-apps and picamera2 config file
> 
>  include/libcamera/internal/pipeline_handler.h |   3 +
>  .../pipeline/raspberrypi/data/default.json    |  28 ++
>  .../pipeline/raspberrypi/data/meson.build     |  10 +
>  .../raspberrypi/data/minimal_mem.json         |  28 ++
>  .../pipeline/raspberrypi/data/rpi_apps.json   |  28 ++
>  .../pipeline/raspberrypi/meson.build          |   2 +
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 239 +++++++++++++++---
>  src/libcamera/pipeline_handler.cpp            |  60 +++++
>  8 files changed, 367 insertions(+), 31 deletions(-)
>  create mode 100644 src/libcamera/pipeline/raspberrypi/data/default.json
>  create mode 100644 src/libcamera/pipeline/raspberrypi/data/meson.build
>  create mode 100644 src/libcamera/pipeline/raspberrypi/data/minimal_mem.json
>  create mode 100644 src/libcamera/pipeline/raspberrypi/data/rpi_apps.json