[libcamera-devel,v2,00/10] Raspberry Pi: Horizontal blanking control
mbox series

Message ID 20221006131744.5179-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi: Horizontal blanking control
Related show

Message

Naushir Patuck Oct. 6, 2022, 1:17 p.m. UTC 
Hi,

Here is version 2 of this series.  I think I've captured all of the review
feedback and suggestions. Notable changes are:

Patch 1/10 - Set the HBLANK to the minimum value in sensor init.
Patch 4/10 - Remove unused initialized_ field in the CamHelper.
Patch 5/10 - Add HBLANK delay values to imx296.

I still need to investigate more with imx296 HBLANK control, right now it's
left at a fixed value.

Regards,
Naush

Naushir Patuck (10):
  camera_sensor: Add minimum and maximum line length to
    IPACameraSensorInfo
  ipa: raspberrypi: Add minimum and maximum line length fields to
    CameraMode
  ipa: raspberrypi: Pass lineLength into the CamHelper API
  ipa: raspberrypi: Remove initialized_ field from CamHelper
  pipeline: ipa: raspberrypi: Add HBLANK control to DelayedControls
  ipa: raspberrypi: Add pixel clock rate to the CameraMode structure
  ipa: raspberrypi: Add line length calculations helper functions
  ipa: raspberrypi: Add line length to DeviceStatus
  ipa: raspberrypi: Allow full line length control
  ipa: raspberrypi: Extract line length from the embedded data parser

 include/libcamera/ipa/core.mojom              | 21 +++--
 include/libcamera/ipa/raspberrypi.mojom       |  1 +
 src/ipa/ipu3/ipu3.cpp                         |  6 +-
 src/ipa/raspberrypi/cam_helper.cpp            | 91 +++++++++++++------
 src/ipa/raspberrypi/cam_helper.h              | 19 ++--
 src/ipa/raspberrypi/cam_helper_imx219.cpp     | 10 +-
 src/ipa/raspberrypi/cam_helper_imx290.cpp     |  5 +-
 src/ipa/raspberrypi/cam_helper_imx296.cpp     | 16 ++--
 src/ipa/raspberrypi/cam_helper_imx477.cpp     | 39 +++++---
 src/ipa/raspberrypi/cam_helper_imx519.cpp     | 39 +++++---
 src/ipa/raspberrypi/cam_helper_ov5647.cpp     |  5 +-
 src/ipa/raspberrypi/cam_helper_ov9281.cpp     |  5 +-
 src/ipa/raspberrypi/controller/camera_mode.h  | 25 +++--
 .../raspberrypi/controller/device_status.cpp  |  1 +
 .../raspberrypi/controller/device_status.h    |  4 +-
 src/ipa/raspberrypi/raspberrypi.cpp           | 61 ++++++++-----
 src/ipa/rkisp1/rkisp1.cpp                     |  2 +-
 src/libcamera/camera_sensor.cpp               | 15 ++-
 .../pipeline/raspberrypi/raspberrypi.cpp      |  1 +
 19 files changed, 247 insertions(+), 119 deletions(-)