[libcamera-devel,v2,0/2] LogCategory fixing
mbox series

Message ID 20220829084445.61585-1-tomi.valkeinen@ideasonboard.com
Headers show
Series
  • LogCategory fixing
Related show

Message

Tomi Valkeinen Aug. 29, 2022, 8:44 a.m. UTC 
Hi,

Changes to v1:

- Use char * instead of string, as that is the style used in log.cpp
- Fix review comments wrt. doc strings
- Drop the ASSERT()

I decided to drop the string uses and keep using char *, as that seems
to be the overall style in log.cpp. I do like strings better, or
string_views where applicable, but perhaps converting only small parts
of the file to use those classes in the context of this bug fix is
unnecessary.

 Tomi

Tomi Valkeinen (2):
  libcamera: base: log: Fix use of freed name
  libcamera: base: log: Fix LogCategory creation issues

 include/libcamera/base/log.h | 10 ++++---
 src/libcamera/base/log.cpp   | 51 +++++++++++++++++++++++++++++++-----
 2 files changed, 50 insertions(+), 11 deletions(-)