From patchwork Mon Aug 29 08:44:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 17217 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 23673C0DA4 for ; Mon, 29 Aug 2022 08:45:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 64FFA61FC4; Mon, 29 Aug 2022 10:44:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661762699; bh=88lhA+whrF8HVN3kom5ZzkHmIsiQcJP24gVN4mEHkTg=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=J+QFKrbfWiyCS/jl+O0ceqaN5UAghMb99JsBRD01lBHb8KHdlj1Tyb9he4MIKWPeV ct3t5sAMM6rcDFpF9VLZFJKRC98IbXjcrJGO5A0KcEMvRay+MWN0Caaxmy/02OMqwA 4WSeOinZmc/zz2HFuDpatO7xRS1Vft11eIfXBqI4mUQVW7+XS6EGP4b/kuoPkAxaWl 6aMZBdC5Z3u1M2bxnbiLT13ieqJk9E9D3WiFi4QO/5nitvNlsfTRIeGJH/9KjtgNzc nAdEIYgAt5h3zwd7pPFWkKgGrZfMnP0tRFgpbQu4YKEGbwwasFpwMe6cKM8lRDVhyP EB1zz1GVy/ogw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 41A1161F9F for ; Mon, 29 Aug 2022 10:44:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="T7ERtCej"; dkim-atps=neutral Received: from deskari.lan (91-158-154-79.elisa-laajakaista.fi [91.158.154.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A3AC481; Mon, 29 Aug 2022 10:44:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1661762696; bh=88lhA+whrF8HVN3kom5ZzkHmIsiQcJP24gVN4mEHkTg=; h=From:To:Cc:Subject:Date:From; b=T7ERtCejhTlXOwY9KMEXDe+FQ8PrSFBE+uWOfPVdD4LvC/UC/UH7uK6m0H2M6WHGN tWQZw3JsmQCidZKx0tL4flX+Vawasb4EKljZSVLiPjqQpMMaIlAKN7gFOZXmDCJCOK c2tvyqSH0thNE43J0tv/5dFe/n592Q3wl4pPu6qI= To: libcamera-devel , Laurent Pinchart Date: Mon, 29 Aug 2022 11:44:43 +0300 Message-Id: <20220829084445.61585-1-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] LogCategory fixing X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tomi Valkeinen via libcamera-devel From: Tomi Valkeinen Reply-To: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Changes to v1: - Use char * instead of string, as that is the style used in log.cpp - Fix review comments wrt. doc strings - Drop the ASSERT() I decided to drop the string uses and keep using char *, as that seems to be the overall style in log.cpp. I do like strings better, or string_views where applicable, but perhaps converting only small parts of the file to use those classes in the context of this bug fix is unnecessary. Tomi Tomi Valkeinen (2): libcamera: base: log: Fix use of freed name libcamera: base: log: Fix LogCategory creation issues include/libcamera/base/log.h | 10 ++++--- src/libcamera/base/log.cpp | 51 +++++++++++++++++++++++++++++++----- 2 files changed, 50 insertions(+), 11 deletions(-)