[libcamera-devel,RFC,0/4] Fix pipelines for the new AE-related controls
mbox series

Message ID 20210928074959.3489544-1-paul.elder@ideasonboard.com
Headers show
Series
  • Fix pipelines for the new AE-related controls
Related show

Message

Paul Elder Sept. 28, 2021, 7:49 a.m. UTC 
This patch series depends on "controls: Reorganize the AE-related
controls".

This series applies fixes on the pipeline handlers that are affected by
the AE controls change. It is meant not to change behavior, but as we
don't yet have a helper for the AeEnable master control yet, some of
these are hairy.

I would appreciate comments on how the pipeline handlers in this series
handle (temporarily and in the long-run) the new AE-related controls. The
raspberrypi and the rkisp1 pipeline handlers are particularly hairy imo.


Paul Elder (4):
  libcamera: pipeline: uvcvideo: Support the new AE controls
  libcamera: pipeline: raspberrypi: Support the new AE controls
  test: ipa_data_serializer: Remove controls::AeEnable
  libcamera: pipeline: rkisp1: Support the new AE controls

 include/libcamera/ipa/raspberrypi.h           |  3 +-
 src/ipa/raspberrypi/controller/rpi/agc.cpp    | 18 +++++++-
 src/ipa/raspberrypi/controller/rpi/agc.hpp    |  5 +++
 src/ipa/raspberrypi/raspberrypi.cpp           | 42 +++++++++++++++----
 src/ipa/rkisp1/rkisp1.cpp                     | 18 ++++----
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      |  4 +-
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  | 36 ++++++++++++++--
 .../ipa_data_serializer_test.cpp              |  1 -
 8 files changed, 102 insertions(+), 25 deletions(-)