From patchwork Tue Sep 28 07:49:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 13959 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7DC33BDC71 for ; Tue, 28 Sep 2021 07:50:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D830C6918D; Tue, 28 Sep 2021 09:50:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="keGae+y4"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6362A69185 for ; Tue, 28 Sep 2021 09:50:14 +0200 (CEST) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D7CDC3F1; Tue, 28 Sep 2021 09:50:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632815414; bh=Pquu/jnl5iy1BnJSRFv0KZhm2d8fdD8Mi8OcokBmRyA=; h=From:To:Cc:Subject:Date:From; b=keGae+y4g1zFvtom2J0VpMES3wVThNQE7tBEYDwdEfzre31RUFhJCeaSKM1WrNoX9 okTbvHe0vxdRWPsnxT7Q+VA0pbDCOWF3aCaFf1g5+MENXgvFXjgZA5RRprBkZ1V+7E ChMvTMXjQnfWeArMS+uF4Js1Nup0SkLpfh5QrAtE= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Tue, 28 Sep 2021 16:49:55 +0900 Message-Id: <20210928074959.3489544-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 0/4] Fix pipelines for the new AE-related controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series depends on "controls: Reorganize the AE-related controls". This series applies fixes on the pipeline handlers that are affected by the AE controls change. It is meant not to change behavior, but as we don't yet have a helper for the AeEnable master control yet, some of these are hairy. I would appreciate comments on how the pipeline handlers in this series handle (temporarily and in the long-run) the new AE-related controls. The raspberrypi and the rkisp1 pipeline handlers are particularly hairy imo. Paul Elder (4): libcamera: pipeline: uvcvideo: Support the new AE controls libcamera: pipeline: raspberrypi: Support the new AE controls test: ipa_data_serializer: Remove controls::AeEnable libcamera: pipeline: rkisp1: Support the new AE controls include/libcamera/ipa/raspberrypi.h | 3 +- src/ipa/raspberrypi/controller/rpi/agc.cpp | 18 +++++++- src/ipa/raspberrypi/controller/rpi/agc.hpp | 5 +++ src/ipa/raspberrypi/raspberrypi.cpp | 42 +++++++++++++++---- src/ipa/rkisp1/rkisp1.cpp | 18 ++++---- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 36 ++++++++++++++-- .../ipa_data_serializer_test.cpp | 1 - 8 files changed, 102 insertions(+), 25 deletions(-)