[libcamera-devel,v7,0/5] Move and improve AWB structures
mbox series

Message ID 20210913132803.54881-1-jeanmichel.hautbois@ideasonboard.com
Headers show
Series
  • Move and improve AWB structures
Related show

Message

Jean-Michel Hautbois Sept. 13, 2021, 1:27 p.m. UTC 
On the path towards a cleaner and more documented IPA for the IPU3, this
series changes the structures used by the AWB algorithm.

- v7 changes a bit of naming in the Awb::generateAwbStats function to
  make it even clearer.
- v6 adds a real better documentation in the AWB part (thanks Kieran) and
properly defines the terms used in the algorithm (cell and zone). A new
patch appears which is here to make it consistent.
- v5 is a small rewording of the commit messages for 2/4 and 4/4.
- v4 changes the way the structure is used in intel-ipu3.h to avoid
any change in the buffer size. It should be transparent.

Patch 1/5 moves the AWB structures to be able to use those from the
ipa::ipu3::algorithms namespace (by AGC at least).

Patch 2/5 renames the stats region structure to make it clear it is an
accumulator structure.

Patch 3/5 is improving the Accumulator structure to have the same layout
as the IPAFrameContext::awb structure.

Patch 4/5 is removing the IPU3AwbCell from libcamera, and uses its
definition directly from the kernel header.

And if the cover letter has been read until here, there is no need to
present patch 5/5 ;-).

Jean-Michel Hautbois (5):
  ipa: ipu3: Move the AWB stats structures
  ipa: ipu3: Rename IspStatsRegion to Accumulator
  ipa: ipu3: Change Accumulator structure layout
  ipa: ipu3: Replace ipa::ipu3::algorithms::Ipu3AwbCell
  ipa: ipu3: awb: Make the naming consistent

 include/linux/intel-ipu3.h      |  28 +++++++-
 src/ipa/ipu3/algorithms/agc.cpp |   7 +-
 src/ipa/ipu3/algorithms/awb.cpp | 123 +++++++++++++++++++++-----------
 src/ipa/ipu3/algorithms/awb.h   |  30 +++-----
 4 files changed, 124 insertions(+), 64 deletions(-)