| Message ID | tencent_E95076CE1FA044AA7EB75BBEA50D19691908@qq.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Siyuan, On Tue, Aug 10, 2021 at 01:17:38PM +0100, Siyuan Fan wrote: > From: Fan Siyuan <siyuan.fan@foxmail.com> > > This patch series fix some of issues raised last commits. Now the test module of > software isp can output the RGB888 format image. I see that this v2 is on top of v1. Your git history probably looks something like this: v2 4/4 <- HEAD v2 3/4 v2 2/4 v2 1/4 v1 4/4 v1 3/4 v1 2/4 v1 1/4 origin/master This won't work, as when we do merge the series we will only have the latest version. We're also unable to review your patches at all, since we're missing so much context. Your git history needs to be like: v2 4/4 <- HEAD v2 3/4 v2 2/4 v2 1/4 origin/master I hope that makes sense. You can use git rebase -i to combine patches and modify history. Make sure to study up on it first though, so that you don't destroy your git history (you can always recover by checking out your original HEAD). Paul > Patch 1/4 fixs the pipeline handler and make it more concise. Patch 2/4 moves the > previous ISP process to libcamera/swisp for general API interface. Patch 3/4 adds > the friend class CPU_ISP in class FrameBuffer to access the private member metadata_. > Patch 4/4 modifies the dependent file path. > > Fan Siyuan (4): > pipeline: isp: The software ISP-based pipeline handler > libcamera: swisp: Move the softawre ISP process to swisp > libcamera: framebuffer: Add the friend class CPU_ISP > pipeline: isp: Modify the dependent file path > > include/libcamera/framebuffer.h | 1 + > src/libcamera/pipeline/isp/isp.cpp | 81 +++++++---------- > src/libcamera/pipeline/isp/meson.build | 4 +- > .../isp/isp_processing.cpp => swisp/isp.cpp} | 90 ++++++++++++++----- > .../isp/isp_processing.h => swisp/isp.h} | 52 ++++++++--- > 5 files changed, 146 insertions(+), 82 deletions(-) > rename src/libcamera/{pipeline/isp/isp_processing.cpp => swisp/isp.cpp} (87%) > rename src/libcamera/{pipeline/isp/isp_processing.h => swisp/isp.h} (54%) > > -- > 2.20.1 >
From: Fan Siyuan <siyuan.fan@foxmail.com> This patch series fix some of issues raised last commits. Now the test module of software isp can output the RGB888 format image. Patch 1/4 fixs the pipeline handler and make it more concise. Patch 2/4 moves the previous ISP process to libcamera/swisp for general API interface. Patch 3/4 adds the friend class CPU_ISP in class FrameBuffer to access the private member metadata_. Patch 4/4 modifies the dependent file path. Fan Siyuan (4): pipeline: isp: The software ISP-based pipeline handler libcamera: swisp: Move the softawre ISP process to swisp libcamera: framebuffer: Add the friend class CPU_ISP pipeline: isp: Modify the dependent file path include/libcamera/framebuffer.h | 1 + src/libcamera/pipeline/isp/isp.cpp | 81 +++++++---------- src/libcamera/pipeline/isp/meson.build | 4 +- .../isp/isp_processing.cpp => swisp/isp.cpp} | 90 ++++++++++++++----- .../isp/isp_processing.h => swisp/isp.h} | 52 ++++++++--- 5 files changed, 146 insertions(+), 82 deletions(-) rename src/libcamera/{pipeline/isp/isp_processing.cpp => swisp/isp.cpp} (87%) rename src/libcamera/{pipeline/isp/isp_processing.h => swisp/isp.h} (54%)