[libcamera-devel,v2,0/2] Raspberrypi: support per-mode camera sensitivities
mbox series

Message ID 20210602152122.14836-1-david.plowman@raspberrypi.com
Headers show
Series
  • Raspberrypi: support per-mode camera sensitivities
Related show

Message

David Plowman June 2, 2021, 3:21 p.m. UTC
Hi again everyone

Here's a quick version 2 of this set. Only the first of the two
patches is changed. I'm still somewhat drawn to the idea of having the
sensitivity in the CameraMode, but I've changed the mechanism to be a
bit more obvious. The comments are explaining it better now, I think,
and there's generally a bit less apologising going on!

Finally I'm still hoping to hear people's opinions on how the
application can learn the mode's sensitivity, even before starting the
camera. I think it's a feature that will be required, though it can
follow in a subsequent patch.

Thanks and best regards

David

David Plowman (2):
  ipa: raspberrypi: Add sensitivity field to camera mode
  ipa: raspberrypi: AGC: handle modes with different sensitivities

 src/ipa/raspberrypi/cam_helper.cpp           | 11 +++++++++
 src/ipa/raspberrypi/cam_helper.hpp           |  3 +++
 src/ipa/raspberrypi/controller/camera_mode.h |  2 ++
 src/ipa/raspberrypi/controller/rpi/agc.cpp   | 25 ++++++++++++++++----
 src/ipa/raspberrypi/controller/rpi/agc.hpp   |  1 +
 src/ipa/raspberrypi/raspberrypi.cpp          |  6 +++++
 6 files changed, 43 insertions(+), 5 deletions(-)