From patchwork Wed Jun 2 15:21:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 12489 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F0B72C3208 for ; Wed, 2 Jun 2021 15:21:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 258596050E; Wed, 2 Jun 2021 17:21:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="BaA5B0Z+"; dkim-atps=neutral Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B97B9602A4 for ; Wed, 2 Jun 2021 17:21:26 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id t16-20020a05600c1990b02901a0d45ff03aso471760wmq.2 for ; Wed, 02 Jun 2021 08:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iHfbBQ0RwHFgGo3MvFtIWXcl8BOlGTcyJNyioiER4P8=; b=BaA5B0Z+cr1X7zymB9itlmiN5lWUZRE+DbL4uRZNL7S6qWEywkmytlu/pD/NPgRXV4 1yGLzZSDMApkKVHxUHEy+f3SeGJbT0Q9r+qKuWRSRFXzrR1XL1ol0kraKGSbUdiEdPLN Ey0OBoSq6RGVS5R8ZVYEHmTZ0P6dKbSEkQ5/DcJ9xP23xy4v3JAwgmhr98zipcft8WXS h4dZi3+5Ion1F4/DT9r2Lkh9ozfmJckUUc59o+ZKZFI4q2qc2kXw4a2ihBN/D2DTM/Dv KDMyyyTPolDi80dbi9qwd9qUWlMeD9B0wLxsxeDXx1aHJIETDxByP3Nf/GtOozordlg4 zzpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iHfbBQ0RwHFgGo3MvFtIWXcl8BOlGTcyJNyioiER4P8=; b=Z5LCK4Z9fOif21Jh9VraTWvGTTvD7LLHKAci+p8dhS4yNXBoU29lnSlnoi2WFMPvYe A2TDHokNInVdfAWe9MYPhv7r7spt1ITbrmi0A2paigrAMQxLT1UrgUxJ/hnGlDjocYV6 w5EV7K6VP2EQ0Fq3fktpactfrYV8Mj+57Hs4n/UiVViWG/7qHSn/dnlzSoHdhmf7agkP JyQ2CvOWGz/6FDsqMdpOrCfRwKg6gfsKrB3QEUHTo9FuPlo+cdq7g54WHSy60DhaRPJO VALDdwMQWdin5Y3wx4kjTIKzxMRI1zr5AX9ZK2baYD+UHF+J5HFSiAeBWfNqTb4VVW1Q kStA== X-Gm-Message-State: AOAM530StlWzq2y27Is1c4c4NEzI5m/5YNVedHTcc8QYgwIblmq76hJR DfrHGrESpnSUOPaTUustOppE/gpHBQizDo6b X-Google-Smtp-Source: ABdhPJwsPG4fV3FcuEPrLDRD9VkSg5mfceJceSvRauw7Rfbt0wFpGtsR9m1TwhWC0jISPlFdIOFgoQ== X-Received: by 2002:a05:600c:1551:: with SMTP id f17mr5500821wmg.17.1622647285993; Wed, 02 Jun 2021 08:21:25 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id p1sm57044wmc.11.2021.06.02.08.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 08:21:25 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Wed, 2 Jun 2021 16:21:20 +0100 Message-Id: <20210602152122.14836-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] Raspberrypi: support per-mode camera sensitivities X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi again everyone Here's a quick version 2 of this set. Only the first of the two patches is changed. I'm still somewhat drawn to the idea of having the sensitivity in the CameraMode, but I've changed the mechanism to be a bit more obvious. The comments are explaining it better now, I think, and there's generally a bit less apologising going on! Finally I'm still hoping to hear people's opinions on how the application can learn the mode's sensitivity, even before starting the camera. I think it's a feature that will be required, though it can follow in a subsequent patch. Thanks and best regards David David Plowman (2): ipa: raspberrypi: Add sensitivity field to camera mode ipa: raspberrypi: AGC: handle modes with different sensitivities src/ipa/raspberrypi/cam_helper.cpp | 11 +++++++++ src/ipa/raspberrypi/cam_helper.hpp | 3 +++ src/ipa/raspberrypi/controller/camera_mode.h | 2 ++ src/ipa/raspberrypi/controller/rpi/agc.cpp | 25 ++++++++++++++++---- src/ipa/raspberrypi/controller/rpi/agc.hpp | 1 + src/ipa/raspberrypi/raspberrypi.cpp | 6 +++++ 6 files changed, 43 insertions(+), 5 deletions(-)