[libcamera-devel,v4,0/4] Raspberry Pi: Embedded data usage
mbox series

Message ID 20210302151111.212591-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi: Embedded data usage
Related show

Message

Naushir Patuck March 2, 2021, 3:11 p.m. UTC 
Hi all,

This version 4 of the patch set address the following changes from v3:
- Typo fixes in patch 1/4.
- Drop nullptr test on delete in patch 2/4.
- Use std::move in RPiCameraData::findMatchingBuffers() to avoid copying
ControlList maps in 
- Fix typo in commit message and line wrap in patch 3/4.

Still to be addressed, but at a later date(?):
- Allow modification of the ipa::init() signature through mojom so that we could
keep the embedded data node closed at PipelineHandler::match().

Regards,
Naush

 include/libcamera/ipa/raspberrypi.mojom       |   2 +
 src/ipa/raspberrypi/cam_helper.cpp            |   6 +-
 src/ipa/raspberrypi/cam_helper_imx219.cpp     |   4 +-
 src/ipa/raspberrypi/cam_helper_ov5647.cpp     |   3 +-
 src/ipa/raspberrypi/md_parser_rpi.cpp         |  37 ----
 src/ipa/raspberrypi/md_parser_rpi.hpp         |  32 ---
 src/ipa/raspberrypi/meson.build               |   1 -
 src/ipa/raspberrypi/raspberrypi.cpp           | 132 +++++++-----
 .../pipeline/raspberrypi/raspberrypi.cpp      | 199 +++++++++++-------
 9 files changed, 211 insertions(+), 205 deletions(-)
 delete mode 100644 src/ipa/raspberrypi/md_parser_rpi.cpp
 delete mode 100644 src/ipa/raspberrypi/md_parser_rpi.hpp