From patchwork Tue Mar 2 15:11:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11461 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 50FB5BD1F1 for ; Tue, 2 Mar 2021 15:11:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C9C1F68A93; Tue, 2 Mar 2021 16:11:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="C8fR3xBl"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 50C7568A7E for ; Tue, 2 Mar 2021 16:11:21 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id h98so20222432wrh.11 for ; Tue, 02 Mar 2021 07:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nYpYpSVkce5XgOgD2yhtOz4HIt3qb3v6lNqjYiWMYEI=; b=C8fR3xBlrSw8mpehtfgmgN/1job2fBA+JWi8e5HEc5FhYIZZ8LAXBpJbAtwBslLIK7 RLmAwT0AIHMPM2vaqWBljpXXEBY6Y/Sa4JCP7ct5gaS/ZZjDeCaV0byZXP9xrarzJueE /Pe9XgBPWWdwnw0i1F5qGfNEDBh9jcfHRKA4rh1/r47gM4G1gk1oxfYFUEkYh0wQmMpe i4gfX7LjoBjknr4+nZoVgbfWbVzinK7HIZlfKUR8dD2NGSGoQsdkIYKL9Wh9XenUWeHF hzu9kDYDtYWEZZfIUML7+L0BvVMZFKuDfnzqqduznCfNAZKFIupX0RGe3myWcnDtrl8N lXhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nYpYpSVkce5XgOgD2yhtOz4HIt3qb3v6lNqjYiWMYEI=; b=aORrIj8BWb71WHlygsOxPjwIdnhGGB/cL249LTsHUma5lkcuftZ7dIQG/vqT7/O2E6 O9SsKADKbrCxYiEGxasE3ka+zpmIYzMYeM97EZZ/Kbi0btvv5pvFffs4kOPuQ5DUcmaD sWo0nuSB1rjVLQSbc9+6TFbxvc9xfEZpRMj51LeR9FK0TkfJoPoL+AOXlus35UwPfwFu MH35hyH4/Ew4iEhv3XJzCl76ldxvlDyHsM2398Qmmwdizjo01NeK2n3JUoZqS80yI7T5 LtoinY8DUO9rE2hsTQaRuIzXP9jRiTy5YP34phBwCwVjLELr+vSCLAt9dtNa3cFBdKte sUDQ== X-Gm-Message-State: AOAM5336/w1ygVyWU+7isVk5cQ/sUNKW09SEqxsUCe7RGuDNXJgfU5Ls IMg8I6PZ+6tT7ehS/Y01BpNktwUuFl9F+ou5 X-Google-Smtp-Source: ABdhPJyUIW3abppP8vf3FIDOGH/ueHK5S/f1wAU/GG1OQUP+vrGRzq5jj7GBcGAnPbQS74teKFqgyw== X-Received: by 2002:adf:de11:: with SMTP id b17mr22917998wrm.196.1614697880677; Tue, 02 Mar 2021 07:11:20 -0800 (PST) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id w6sm7561062wrl.49.2021.03.02.07.11.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 07:11:20 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 2 Mar 2021 15:11:07 +0000 Message-Id: <20210302151111.212591-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/4] Raspberry Pi: Embedded data usage X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, This version 4 of the patch set address the following changes from v3: - Typo fixes in patch 1/4. - Drop nullptr test on delete in patch 2/4. - Use std::move in RPiCameraData::findMatchingBuffers() to avoid copying ControlList maps in - Fix typo in commit message and line wrap in patch 3/4. Still to be addressed, but at a later date(?): - Allow modification of the ipa::init() signature through mojom so that we could keep the embedded data node closed at PipelineHandler::match(). Regards, Naush include/libcamera/ipa/raspberrypi.mojom | 2 + src/ipa/raspberrypi/cam_helper.cpp | 6 +- src/ipa/raspberrypi/cam_helper_imx219.cpp | 4 +- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 3 +- src/ipa/raspberrypi/md_parser_rpi.cpp | 37 ---- src/ipa/raspberrypi/md_parser_rpi.hpp | 32 --- src/ipa/raspberrypi/meson.build | 1 - src/ipa/raspberrypi/raspberrypi.cpp | 132 +++++++----- .../pipeline/raspberrypi/raspberrypi.cpp | 199 +++++++++++------- 9 files changed, 211 insertions(+), 205 deletions(-) delete mode 100644 src/ipa/raspberrypi/md_parser_rpi.cpp delete mode 100644 src/ipa/raspberrypi/md_parser_rpi.hpp