[libcamera-devel,v2,0/2] Raspberry Pi AWB race condition and maintenance
mbox series

Message ID 20210210175830.32038-1-david.plowman@raspberrypi.com
Headers show
Series
  • Raspberry Pi AWB race condition and maintenance
Related show

Message

David Plowman Feb. 10, 2021, 5:58 p.m. UTC 
Hi

Thanks for the reviews. This v2 set is identical but for the addition
of an isAutoEnabled() method, as suggested. In the other patch I've
fixed a typo in the commit message (no prizes for spotting what it
was!).

Best regards
David

David Plowman (2):
  ipa: raspberrypi: AWB: Remove unnecessary frame count variable
  ipa: raspberrypi: AWB: Fix race condition setting manual gains

 src/ipa/raspberrypi/controller/rpi/awb.cpp | 90 +++++++++++-----------
 src/ipa/raspberrypi/controller/rpi/awb.hpp |  2 +-
 2 files changed, 45 insertions(+), 47 deletions(-)

Comments

Laurent Pinchart Feb. 11, 2021, 4:25 p.m. UTC | #1 
Hi David,

On Wed, Feb 10, 2021 at 05:58:28PM +0000, David Plowman wrote:
> Hi
> 
> Thanks for the reviews. This v2 set is identical but for the addition
> of an isAutoEnabled() method, as suggested. In the other patch I've
> fixed a typo in the commit message (no prizes for spotting what it
> was!).

I'm afraid I had alreadu pushed the previous version of 1/2, so the typo
will make it to posterity, sorry about that :-)

2/2 looks good, I'll push it shortly after the tests finish running.

> David Plowman (2):
>   ipa: raspberrypi: AWB: Remove unnecessary frame count variable
>   ipa: raspberrypi: AWB: Fix race condition setting manual gains
> 
>  src/ipa/raspberrypi/controller/rpi/awb.cpp | 90 +++++++++++-----------
>  src/ipa/raspberrypi/controller/rpi/awb.hpp |  2 +-
>  2 files changed, 45 insertions(+), 47 deletions(-)