From patchwork Wed Feb 10 17:58:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 11208 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B7455BD160 for ; Wed, 10 Feb 2021 17:58:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2348E61634; Wed, 10 Feb 2021 18:58:36 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Z8Crrp1x"; dkim-atps=neutral Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B974C602FE for ; Wed, 10 Feb 2021 18:58:34 +0100 (CET) Received: by mail-ej1-x62d.google.com with SMTP id lg21so5768889ejb.3 for ; Wed, 10 Feb 2021 09:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uXg7MkiEHKODVeL7KhFx5KybEV9DZ6QkbPOdRJGmFaY=; b=Z8Crrp1xq+vaFuhozHs7pQzAJBjMV3IQ6WaF1MfgJcvggP+P4tD2pzKdOyPWIn83DB Ryay8gKtYKwzs+O2WTw2YH0+UTyu5JcbX5Vp+sF1CQxPC/ExzgyzGkWanGZNbc4PPLtL tlY+a4FmoY6pvsQfCEIUxUV+jm+2YvCvZ6NJ05hreiXl6bU74Y14d0V1eOGuxTKW3rrI jhPVPI0gHHjgllxCKuLzJiQ9zprzCD7Usf7BHp2vTINbpMe560cN74kBMQ/SUwwkEeIp FMHwP30y1nyJvZsGeELUplN5avGwFMz2iD/q9eDU8RNH3qCvJM7eORB7cReQgz5vsUZ2 0K8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uXg7MkiEHKODVeL7KhFx5KybEV9DZ6QkbPOdRJGmFaY=; b=QjD8NE6mfM8YQe1twjoxKTWD1e9WnLfEsnwIGtTa6A89mvtsKnwZQLgv9QJK2Gaol/ zyj2KSl3CAy0b18slS+Z0bibD72hS8vVwfig1MVwXy/li4jvCL4XViLy9wLWwzrzBB1V 00y+HAO0bw5Oi5JoG8zx44FrK7oup/VyOyyAVTduAX9Vdxq902jEezBR7/jGGNLnHKsT go+4nEIJCEnwC/R7quvQ3RihK23SjJ97ox4YyeS+4Tk7OkW+Eq0WW+RhXgW9Ey5dAaIx lWwgszqQAjZXdzifMKGIpsL3HuK2ZQqxmCZE/dVKHMJEHvb1+aKRRrdrEdyTY9fHjBkE nG3g== X-Gm-Message-State: AOAM531ClnKmBrRFbEpUqUda3S98BohLCqKVww/w/EaWEXSox/wMmiR3 5j9MqRtaeVLCoeRBNvu933SeR4Yu6poO1p7Z X-Google-Smtp-Source: ABdhPJwItw3RXfw1obEte1WPmct6mbVyiFrB+nUMwPx9eERZgWzIscROlVRJva/NGbBTgeQ3IvgD3g== X-Received: by 2002:a17:906:391b:: with SMTP id f27mr4008648eje.228.1612979914151; Wed, 10 Feb 2021 09:58:34 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id hc13sm1660483ejc.5.2021.02.10.09.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 09:58:33 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Wed, 10 Feb 2021 17:58:28 +0000 Message-Id: <20210210175830.32038-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] Raspberry Pi AWB race condition and maintenance X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Thanks for the reviews. This v2 set is identical but for the addition of an isAutoEnabled() method, as suggested. In the other patch I've fixed a typo in the commit message (no prizes for spotting what it was!). Best regards David David Plowman (2): ipa: raspberrypi: AWB: Remove unnecessary frame count variable ipa: raspberrypi: AWB: Fix race condition setting manual gains src/ipa/raspberrypi/controller/rpi/awb.cpp | 90 +++++++++++----------- src/ipa/raspberrypi/controller/rpi/awb.hpp | 2 +- 2 files changed, 45 insertions(+), 47 deletions(-)