Message ID | 20200605183833.8125-3-laurent.pinchart@ideasonboard.com |
---|---|
State | Accepted |
Commit | 0aed5a4e4a30598edb1ad759405800e991ef1e8e |
Headers | show |
Series |
|
Related | show |
Hi Laurent, Thanks for your work. On 2020-06-05 21:38:33 +0300, Laurent Pinchart wrote: > Specify the license of the Feather icons files in the .reuse/dep5 file. > Technically speaking the SVG format supports comments, SPDX could thus > be used, but that would be impractical both due to the large number of > files, and the fact that they would then diverge from the upstream > project. > > We can remove the README.md file, as it now only contains redundant or > incorrect information: the license and project URL are contained in the > DEP5 file, and the comment related to generation of the GRC file is > outdated as the file is now manually edited to only include the icons > that we need. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > .reuse/dep5 | 5 +++++ > src/qcam/assets/feathericons/README.md | 5 ----- > 2 files changed, 5 insertions(+), 5 deletions(-) > delete mode 100644 src/qcam/assets/feathericons/README.md > > diff --git a/.reuse/dep5 b/.reuse/dep5 > index c05441cfb270..a66f27e7fedd 100644 > --- a/.reuse/dep5 > +++ b/.reuse/dep5 > @@ -8,3 +8,8 @@ Files: src/ipa/raspberrypi/data/*.json > utils/raspberrypi/ctt/ctt_ref.pgm > Copyright: 2019-2020 Raspberry Pi (Trading) Ltd. > License: BSD-2-Clause > + > +Files: src/qcam/assets/feathericons/*.svg > +Copyright: 2019 Cole Bemis (and other Feather icons contributors) > +License: MIT > +Comment: https://feathericons.com/ > diff --git a/src/qcam/assets/feathericons/README.md b/src/qcam/assets/feathericons/README.md > deleted file mode 100644 > index ce7664f6bf16..000000000000 > --- a/src/qcam/assets/feathericons/README.md > +++ /dev/null > @@ -1,5 +0,0 @@ > -Icons from https://feathericons.com/ > -License: MIT > - > -Generate the QRC file with: > - rcc --project > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/.reuse/dep5 b/.reuse/dep5 index c05441cfb270..a66f27e7fedd 100644 --- a/.reuse/dep5 +++ b/.reuse/dep5 @@ -8,3 +8,8 @@ Files: src/ipa/raspberrypi/data/*.json utils/raspberrypi/ctt/ctt_ref.pgm Copyright: 2019-2020 Raspberry Pi (Trading) Ltd. License: BSD-2-Clause + +Files: src/qcam/assets/feathericons/*.svg +Copyright: 2019 Cole Bemis (and other Feather icons contributors) +License: MIT +Comment: https://feathericons.com/ diff --git a/src/qcam/assets/feathericons/README.md b/src/qcam/assets/feathericons/README.md deleted file mode 100644 index ce7664f6bf16..000000000000 --- a/src/qcam/assets/feathericons/README.md +++ /dev/null @@ -1,5 +0,0 @@ -Icons from https://feathericons.com/ -License: MIT - -Generate the QRC file with: - rcc --project
Specify the license of the Feather icons files in the .reuse/dep5 file. Technically speaking the SVG format supports comments, SPDX could thus be used, but that would be impractical both due to the large number of files, and the fact that they would then diverge from the upstream project. We can remove the README.md file, as it now only contains redundant or incorrect information: the license and project URL are contained in the DEP5 file, and the comment related to generation of the GRC file is outdated as the file is now manually edited to only include the icons that we need. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .reuse/dep5 | 5 +++++ src/qcam/assets/feathericons/README.md | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) delete mode 100644 src/qcam/assets/feathericons/README.md