[v5,11/24] ipa: libipa: agc: Do not report auto controls if not available
diff mbox series

Message ID 20261029125844.170324-12-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • ipa: libipa: agc: Take exposure margin into account
Related show

Commit Message

Barnabás Pőcze Oct. 29, 2026, 12:58 p.m. UTC 
If the auto mode is disabled for the session, do not report controls
in metadata that are related to controlling the auto algorithm.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/agc.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Kieran Bingham Oct. 29, 2026, 4:12 p.m. UTC | #1 
Quoting Barnabás Pőcze (2026-10-29 12:58:31)
> If the auto mode is disabled for the session, do not report controls
> in metadata that are related to controlling the auto algorithm.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/libipa/agc.cpp | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
> index fd40fbdeb3..0d25b2dc31 100644
> --- a/src/ipa/libipa/agc.cpp
> +++ b/src/ipa/libipa/agc.cpp
> @@ -1130,9 +1130,11 @@ void AgcAlgorithm::fillMetadata(const agc::Session &session,
>                                                  ? controls::AnalogueGainModeAuto
>                                                  : controls::AnalogueGainModeManual);
>  
> -       metadata.set(controls::AeExposureMode, frameContext.exposureMode);
> -       metadata.set(controls::AeConstraintMode, frameContext.constraintMode);
> -       metadata.set(controls::ExposureValue, frameContext.exposureValue);
> +       if (session.autoAllowed) {
> +               metadata.set(controls::AeExposureMode, frameContext.exposureMode);
> +               metadata.set(controls::AeConstraintMode, frameContext.constraintMode);
> +               metadata.set(controls::ExposureValue, frameContext.exposureValue);
> +       }
>  }
>  
>  } /* namespace ipa */
> -- 
> 2.56.0
>

Patch
diff mbox series 

diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
index fd40fbdeb3..0d25b2dc31 100644
--- a/src/ipa/libipa/agc.cpp
+++ b/src/ipa/libipa/agc.cpp
@@ -1130,9 +1130,11 @@  void AgcAlgorithm::fillMetadata(const agc::Session &session,
 						 ? controls::AnalogueGainModeAuto
 						 : controls::AnalogueGainModeManual);
 
-	metadata.set(controls::AeExposureMode, frameContext.exposureMode);
-	metadata.set(controls::AeConstraintMode, frameContext.constraintMode);
-	metadata.set(controls::ExposureValue, frameContext.exposureValue);
+	if (session.autoAllowed) {
+		metadata.set(controls::AeExposureMode, frameContext.exposureMode);
+		metadata.set(controls::AeConstraintMode, frameContext.constraintMode);
+		metadata.set(controls::ExposureValue, frameContext.exposureValue);
+	}
 }
 
 } /* namespace ipa */