[v5,01/24] libcamera: controls: AeExposureMode: Add ExposureMaximize
diff mbox series

Message ID 20261029125844.170324-2-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • ipa: libipa: agc: Take exposure margin into account
Related show

Commit Message

Barnabás Pőcze Oct. 29, 2026, 12:58 p.m. UTC
Add a new exposure mode that is intended to make the full capabilities
of a sensor available for applications, potentially allowing multi-second
exposure times and maximal analogue gain.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/control_ids_core.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jacopo Mondi Oct. 29, 2026, 3:35 p.m. UTC | #1
Hi Barnabás

On Thu, Oct 29, 2026 at 01:58:21PM +0100, Barnabás Pőcze wrote:
> Add a new exposure mode that is intended to make the full capabilities
> of a sensor available for applications, potentially allowing multi-second
> exposure times and maximal analogue gain.

maximal or maximum ?

>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  src/libcamera/control_ids_core.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
> index 73643e7e84..d27be4be6a 100644
> --- a/src/libcamera/control_ids_core.yaml
> +++ b/src/libcamera/control_ids_core.yaml
> @@ -188,6 +188,11 @@ controls:
>          - name: Custom
>            value: 3
>            description: Custom exposure mode.
> +        - name: Maximize
> +          value: 4
> +          description: |
> +            Exposure mode allowing very large exposure times and gains,
> +            up to the sensors capabilities.
>
>    - ExposureValue:
>        type: float
> --
> 2.56.0
>
Kieran Bingham Oct. 29, 2026, 4:14 p.m. UTC | #2
Quoting Jacopo Mondi (2026-10-29 15:35:58)
> Hi Barnabás
> 
> On Thu, Oct 29, 2026 at 01:58:21PM +0100, Barnabás Pőcze wrote:
> > Add a new exposure mode that is intended to make the full capabilities
> > of a sensor available for applications, potentially allowing multi-second
> > exposure times and maximal analogue gain.
> 
> maximal or maximum ?


Either is fine with me.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> >
> > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> 
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> 
> > ---
> >  src/libcamera/control_ids_core.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
> > index 73643e7e84..d27be4be6a 100644
> > --- a/src/libcamera/control_ids_core.yaml
> > +++ b/src/libcamera/control_ids_core.yaml
> > @@ -188,6 +188,11 @@ controls:
> >          - name: Custom
> >            value: 3
> >            description: Custom exposure mode.
> > +        - name: Maximize
> > +          value: 4
> > +          description: |
> > +            Exposure mode allowing very large exposure times and gains,
> > +            up to the sensors capabilities.
> >
> >    - ExposureValue:
> >        type: float
> > --
> > 2.56.0
> >

Patch
diff mbox series

diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
index 73643e7e84..d27be4be6a 100644
--- a/src/libcamera/control_ids_core.yaml
+++ b/src/libcamera/control_ids_core.yaml
@@ -188,6 +188,11 @@  controls:
         - name: Custom
           value: 3
           description: Custom exposure mode.
+        - name: Maximize
+          value: 4
+          description: |
+            Exposure mode allowing very large exposure times and gains,
+            up to the sensors capabilities.
 
   - ExposureValue:
       type: float