| Message ID | 20261026122014.61707-1-remy.alipoursafari@collabora.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi On Tue, Oct 27, 2026 at 01:19:57AM +1300, coolGi wrote: > Several small patches originally made to quickly add support for the > Radxa Camera 4K (imx415) with softisp. > While doing this, I also found a quick optimisation with static uniforms > unnecessarily being passed every frame, a redundant check (though, ideally > it should be checking if the values are -1), and LSP folder ignore. > > This is my first time sending patches over email, so please bear with my if > something is odd. Without entering in the patches merit, you'll need: 1) Signoffs with a real name as a valid signature to comply with Developer's Certificate of Origin. 2) Commit messages in every patch You can have more details by reading Documentation/contributing.rst Thanks j > > Thanks in advance! > > coolGi (4): > gitignore: Ignore clang's generated cache folder > libcamera: pipeline: simple: Add rockchip-cif to supported devices > list > libcamera: software_isp: debayer_egl: Remove redundant return value of > getShaderVariableLocations > libcamera: software_isp: debayer_egl: Only assign static uniforms once > > .gitignore | 1 + > src/libcamera/pipeline/simple/simple.cpp | 1 + > src/libcamera/software_isp/debayer_egl.cpp | 28 +++++++++++++--------- > src/libcamera/software_isp/debayer_egl.h | 3 ++- > 4 files changed, 21 insertions(+), 12 deletions(-) > > -- > 2.56.0 >
On Mon, Oct 26, 2026 at 01:29:54PM +0100, Jacopo Mondi wrote: > On Tue, Oct 27, 2026 at 01:19:57AM +1300, coolGi wrote: > > Several small patches originally made to quickly add support for the > > Radxa Camera 4K (imx415) with softisp. > > While doing this, I also found a quick optimisation with static uniforms > > unnecessarily being passed every frame, a redundant check (though, ideally > > it should be checking if the values are -1), and LSP folder ignore. > > > > This is my first time sending patches over email, so please bear with my if > > something is odd. Don't worry. What matters is a will to learn. Perfection on the first try is suspicious these days :-) > Without entering in the patches merit, you'll need: > > 1) Signoffs with a real name as a valid signature to comply with > Developer's Certificate of Origin. > 2) Commit messages in every patch > > You can have more details by reading Documentation/contributing.rst What SoC are you working with ? Have you seen the rkisp2 pipeline handler that Paul has posted ([1]) ? [1] https://lists.libcamera.org/pipermail/libcamera-devel/2026-August/061688.html > > Thanks in advance! > > > > coolGi (4): > > gitignore: Ignore clang's generated cache folder > > libcamera: pipeline: simple: Add rockchip-cif to supported devices > > list > > libcamera: software_isp: debayer_egl: Remove redundant return value of > > getShaderVariableLocations > > libcamera: software_isp: debayer_egl: Only assign static uniforms once > > > > .gitignore | 1 + > > src/libcamera/pipeline/simple/simple.cpp | 1 + > > src/libcamera/software_isp/debayer_egl.cpp | 28 +++++++++++++--------- > > src/libcamera/software_isp/debayer_egl.h | 3 ++- > > 4 files changed, 21 insertions(+), 12 deletions(-)
Heya Jacopo & Laurent, On 2026/10/27 1:43, Laurent Pinchart wrote: > On Mon, Oct 26, 2026 at 01:29:54PM +0100, Jacopo Mondi wrote: >> On Tue, Oct 27, 2026 at 01:19:57AM +1300, coolGi wrote: >>> Several small patches originally made to quickly add support for the >>> Radxa Camera 4K (imx415) with softisp. >>> While doing this, I also found a quick optimisation with static uniforms >>> unnecessarily being passed every frame, a redundant check (though, ideally >>> it should be checking if the values are -1), and LSP folder ignore. >>> >>> This is my first time sending patches over email, so please bear with my if >>> something is odd. > > Don't worry. What matters is a will to learn. Perfection on the first > try is suspicious these days :-) > >> Without entering in the patches merit, you'll need: >> >> 1) Signoffs with a real name as a valid signature to comply with >> Developer's Certificate of Origin. This was intentional as I feel more comfortable under the "coolGi" pseudonym and am known as that (yes, I do know my email gives out my real name as well, just a preference). I'm happy to change it for v2 of the patch if need be :) >> 2) Commit messages in every patch >> >> You can have more details by reading Documentation/contributing.rst I did look at that document, however the patch subjects (outside of the 4th one, which I'll be more thorough on) are kinda self explanatory 😅. I'll try to add a description for the rest of the patches. > > What SoC are you working with ? Have you seen the rkisp2 pipeline > handler that Paul has posted ([1]) ? > > [1] https://lists.libcamera.org/pipermail/libcamera-devel/2026-August/061688.html I am working with the Radxa 5B. I have seen the rkisp2 pipeline, however that doesn't have: - The tuning file for the imx415 (I do know I can add it, however that patch doesn't seem to be for this board also due to the next point) - The hardisp used by that patch at [1] isn't something available on my board. So while my camera does get detected, it can't really do anything outside of outputting its raw (non-processed & non-debayered) contents. [1] https://git.ideasonboard.com/epaul/libcamera/src/commit/16de359d9b25a841e4b6fdf59d432baadb3c5b07/src/libcamera/pipeline/rkisp2/rkisp2.cpp#L1172 Thanks! - coolGi (Remy) > >>> Thanks in advance! >>> >>> coolGi (4): >>> gitignore: Ignore clang's generated cache folder >>> libcamera: pipeline: simple: Add rockchip-cif to supported devices >>> list >>> libcamera: software_isp: debayer_egl: Remove redundant return value of >>> getShaderVariableLocations >>> libcamera: software_isp: debayer_egl: Only assign static uniforms once >>> >>> .gitignore | 1 + >>> src/libcamera/pipeline/simple/simple.cpp | 1 + >>> src/libcamera/software_isp/debayer_egl.cpp | 28 +++++++++++++--------- >>> src/libcamera/software_isp/debayer_egl.h | 3 ++- >>> 4 files changed, 21 insertions(+), 12 deletions(-) >
Several small patches originally made to quickly add support for the Radxa Camera 4K (imx415) with softisp. While doing this, I also found a quick optimisation with static uniforms unnecessarily being passed every frame, a redundant check (though, ideally it should be checking if the values are -1), and LSP folder ignore. This is my first time sending patches over email, so please bear with my if something is odd. Thanks in advance! coolGi (4): gitignore: Ignore clang's generated cache folder libcamera: pipeline: simple: Add rockchip-cif to supported devices list libcamera: software_isp: debayer_egl: Remove redundant return value of getShaderVariableLocations libcamera: software_isp: debayer_egl: Only assign static uniforms once .gitignore | 1 + src/libcamera/pipeline/simple/simple.cpp | 1 + src/libcamera/software_isp/debayer_egl.cpp | 28 +++++++++++++--------- src/libcamera/software_isp/debayer_egl.h | 3 ++- 4 files changed, 21 insertions(+), 12 deletions(-)