[RFC,4/7] ipa: softisp: Remove unused imports from ipa_context.h
diff mbox series

Message ID 20261021080000.16624-5-mzamazal@redhat.com
State Superseded
Headers show
Series
  • Autofocus basics for software ISP
Related show

Commit Message

Milan Zamazal Oct. 21, 2026, 7:59 a.m. UTC
Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 src/ipa/softisp/ipa_context.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Kieran Bingham Oct. 22, 2026, 4:41 p.m. UTC | #1
Quoting Milan Zamazal (2026-10-21 08:59:44)
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>

On the assumption that this is checked by the CI machinery or iwyu

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> ---
>  src/ipa/softisp/ipa_context.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/ipa/softisp/ipa_context.h b/src/ipa/softisp/ipa_context.h
> index 397e6c99b..05643296e 100644
> --- a/src/ipa/softisp/ipa_context.h
> +++ b/src/ipa/softisp/ipa_context.h
> @@ -7,7 +7,6 @@
>  
>  #pragma once
>  
> -#include <array>
>  #include <memory>
>  #include <optional>
>  #include <stdint.h>
> @@ -15,7 +14,6 @@
>  #include <libcamera/controls.h>
>  
>  #include "libcamera/internal/matrix.h"
> -#include "libcamera/internal/vector.h"
>  
>  #include <libipa/agc.h>
>  #include <libipa/awb.h>
> -- 
> 2.56.0
>
Barnabás Pőcze Oct. 22, 2026, 4:48 p.m. UTC | #2
2026. 10. 21. 9:59 keltezéssel, Milan Zamazal írta:
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> ---

clangd also diagnoses these as unused.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/ipa/softisp/ipa_context.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/src/ipa/softisp/ipa_context.h b/src/ipa/softisp/ipa_context.h
> index 397e6c99b..05643296e 100644
> --- a/src/ipa/softisp/ipa_context.h
> +++ b/src/ipa/softisp/ipa_context.h
> @@ -7,7 +7,6 @@
>   
>   #pragma once
>   
> -#include <array>
>   #include <memory>
>   #include <optional>
>   #include <stdint.h>
> @@ -15,7 +14,6 @@
>   #include <libcamera/controls.h>
>   
>   #include "libcamera/internal/matrix.h"
> -#include "libcamera/internal/vector.h"
>   
>   #include <libipa/agc.h>
>   #include <libipa/awb.h>

Patch
diff mbox series

diff --git a/src/ipa/softisp/ipa_context.h b/src/ipa/softisp/ipa_context.h
index 397e6c99b..05643296e 100644
--- a/src/ipa/softisp/ipa_context.h
+++ b/src/ipa/softisp/ipa_context.h
@@ -7,7 +7,6 @@ 
 
 #pragma once
 
-#include <array>
 #include <memory>
 #include <optional>
 #include <stdint.h>
@@ -15,7 +14,6 @@ 
 #include <libcamera/controls.h>
 
 #include "libcamera/internal/matrix.h"
-#include "libcamera/internal/vector.h"
 
 #include <libipa/agc.h>
 #include <libipa/awb.h>