| Message ID | 20261021144139.3366988-2-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Naushir Patuck (2026-10-21 15:41:01) > These sensors belong to the Starvis 2 family, so add their entires to > cam_helper_starvis2. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > index 0a0f75e19c01..5e017aaba9e3 100644 > --- a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > +++ b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > @@ -50,6 +50,8 @@ CamHelper *create() > return new CamHelperStarvis2(); > } > > -RegisterCamHelper reg("imx678", &create); > +RegisterCamHelper reg675("imx675", &create); > +RegisterCamHelper reg678("imx678", &create); > +RegisterCamHelper reg832("imx832", &create); https://lore.kernel.org/linux-media/20261015-media-starvis2-v4-0-75fcdb4163f3@raspberrypi.com/T/#t adds support for - IMX662 - IMX675 - IMX832 - IMX585 Should we add IMX585 here too? I think we're anticipating IMX676 to appear in that list too, which Dave said he'd pick up into his series. Perhaps we could already add that in too. Anyway: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > } /* namespace */ > -- > 2.53.0 >
Hi Kieran Responding on Naush's behalf. On Wed, 21 Oct 2026 at 15:56, Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > > Quoting Naushir Patuck (2026-10-21 15:41:01) > > These sensors belong to the Starvis 2 family, so add their entires to > > cam_helper_starvis2. > > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > --- > > src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > index 0a0f75e19c01..5e017aaba9e3 100644 > > --- a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > +++ b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > @@ -50,6 +50,8 @@ CamHelper *create() > > return new CamHelperStarvis2(); > > } > > > > -RegisterCamHelper reg("imx678", &create); > > +RegisterCamHelper reg675("imx675", &create); > > +RegisterCamHelper reg678("imx678", &create); > > +RegisterCamHelper reg832("imx832", &create); > > https://lore.kernel.org/linux-media/20261015-media-starvis2-v4-0-75fcdb4163f3@raspberrypi.com/T/#t You missed v5 https://lore.kernel.org/r/20261019-media-starvis2-v5-0-eef935347ce9@raspberrypi.com v6 coming very soon to address Sakari's comments and yet more Sashiko comments. > adds support for > - IMX662 > - IMX675 > - IMX832 > - IMX585 > > Should we add IMX585 here too? IMX585 and IMX676 both have different exposure limits to the rest. See the discussion with Jai at https://lists.libcamera.org/pipermail/libcamera-devel/2026-October/062532.html The cam_helper therefore needs some more tweaking to support those two. > I think we're anticipating IMX676 to appear in that list too, which Dave > said he'd pick up into his series. Perhaps we could already add that in > too. I'd offered, but Jai said he'd send it as a reply to my series. HMAX limits still needed to be determined. https://lists.libcamera.org/pipermail/libcamera-devel/2026-October/062533.html Dave > Anyway: > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > > } /* namespace */ > > -- > > 2.53.0 > >
@Cc Jai Quoting Dave Stevenson (2026-10-21 16:23:16) > Hi Kieran > > Responding on Naush's behalf. > > On Wed, 21 Oct 2026 at 15:56, Kieran Bingham > <kieran.bingham@ideasonboard.com> wrote: > > > > Quoting Naushir Patuck (2026-10-21 15:41:01) > > > These sensors belong to the Starvis 2 family, so add their entires to > > > cam_helper_starvis2. > > > > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > > --- > > > src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > > index 0a0f75e19c01..5e017aaba9e3 100644 > > > --- a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > > +++ b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > > @@ -50,6 +50,8 @@ CamHelper *create() > > > return new CamHelperStarvis2(); > > > } > > > > > > -RegisterCamHelper reg("imx678", &create); > > > +RegisterCamHelper reg675("imx675", &create); > > > +RegisterCamHelper reg678("imx678", &create); > > > +RegisterCamHelper reg832("imx832", &create); > > > > https://lore.kernel.org/linux-media/20261015-media-starvis2-v4-0-75fcdb4163f3@raspberrypi.com/T/#t > > You missed v5 > https://lore.kernel.org/r/20261019-media-starvis2-v5-0-eef935347ce9@raspberrypi.com > > v6 coming very soon to address Sakari's comments and yet more Sashiko comments. > > > adds support for > > - IMX662 > > - IMX675 > > - IMX832 > > - IMX585 > > > > Should we add IMX585 here too? > > IMX585 and IMX676 both have different exposure limits to the rest. See > the discussion with Jai at > https://lists.libcamera.org/pipermail/libcamera-devel/2026-October/062532.html > The cam_helper therefore needs some more tweaking to support those two. Ack, they can come separately then. Still gets my tag :D > > > I think we're anticipating IMX676 to appear in that list too, which Dave > > said he'd pick up into his series. Perhaps we could already add that in > > too. > > I'd offered, but Jai said he'd send it as a reply to my series. HMAX > limits still needed to be determined. > https://lists.libcamera.org/pipermail/libcamera-devel/2026-October/062533.html Jai - is there anything to post already ? -- Regards Kieran > > Dave > > > Anyway: > > > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > > > > > > } /* namespace */ > > > -- > > > 2.53.0 > > >
Hi all, Quoting Kieran Bingham (2026-10-21 22:01:44) > @Cc Jai > > Quoting Dave Stevenson (2026-10-21 16:23:16) > > Hi Kieran > > > > Responding on Naush's behalf. > > > > On Wed, 21 Oct 2026 at 15:56, Kieran Bingham > > <kieran.bingham@ideasonboard.com> wrote: > > > > > > Quoting Naushir Patuck (2026-10-21 15:41:01) > > > > These sensors belong to the Starvis 2 family, so add their entires to > > > > cam_helper_starvis2. > > > > > > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > > > --- > > > > src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > > > index 0a0f75e19c01..5e017aaba9e3 100644 > > > > --- a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > > > +++ b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > > > > @@ -50,6 +50,8 @@ CamHelper *create() > > > > return new CamHelperStarvis2(); > > > > } > > > > > > > > -RegisterCamHelper reg("imx678", &create); > > > > +RegisterCamHelper reg675("imx675", &create); > > > > +RegisterCamHelper reg678("imx678", &create); > > > > +RegisterCamHelper reg832("imx832", &create); > > > > > > https://lore.kernel.org/linux-media/20261015-media-starvis2-v4-0-75fcdb4163f3@raspberrypi.com/T/#t > > > > You missed v5 > > https://lore.kernel.org/r/20261019-media-starvis2-v5-0-eef935347ce9@raspberrypi.com > > > > v6 coming very soon to address Sakari's comments and yet more Sashiko comments. > > > > > adds support for > > > - IMX662 > > > - IMX675 > > > - IMX832 > > > - IMX585 > > > > > > Should we add IMX585 here too? > > > > IMX585 and IMX676 both have different exposure limits to the rest. See > > the discussion with Jai at > > https://lists.libcamera.org/pipermail/libcamera-devel/2026-October/062532.html > > The cam_helper therefore needs some more tweaking to support those two. > > Ack, they can come separately then. > > Still gets my tag :D > > > > > > I think we're anticipating IMX676 to appear in that list too, which Dave > > > said he'd pick up into his series. Perhaps we could already add that in > > > too. > > > > I'd offered, but Jai said he'd send it as a reply to my series. HMAX > > limits still needed to be determined. > > https://lists.libcamera.org/pipermail/libcamera-devel/2026-October/062533.html > > > Jai - is there anything to post already ? > I had added my driver on top of the rpi-7.3.y-starvis2 branch last week, but didn't yet get around to testing all link frequencies, and more importantly updating the exposure limits. I see Dave has already done the latter in his series for IMX585, so that should make life easier. I'll post my patch by tomorrow :-) Thanks, Jai > -- > Regards > > Kieran > > > > > > Dave > > > > > Anyway: > > > > > > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > > > > > > > > > > } /* namespace */ > > > > -- > > > > 2.53.0 > > > >
Quoting Naushir Patuck (2026-10-21 20:11:01) > These sensors belong to the Starvis 2 family, so add their entires to > cam_helper_starvis2. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com> > --- > src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > index 0a0f75e19c01..5e017aaba9e3 100644 > --- a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > +++ b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > @@ -50,6 +50,8 @@ CamHelper *create() > return new CamHelperStarvis2(); > } > > -RegisterCamHelper reg("imx678", &create); > +RegisterCamHelper reg675("imx675", &create); > +RegisterCamHelper reg678("imx678", &create); > +RegisterCamHelper reg832("imx832", &create); > > } /* namespace */ > -- > 2.53.0 >
Hi Naush, Quoting Naushir Patuck (2026-10-21 15:41:01) > These sensors belong to the Starvis 2 family, so add their entires to > cam_helper_starvis2. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > index 0a0f75e19c01..5e017aaba9e3 100644 > --- a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > +++ b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp > @@ -50,6 +50,8 @@ CamHelper *create() > return new CamHelperStarvis2(); > } > > -RegisterCamHelper reg("imx678", &create); > +RegisterCamHelper reg675("imx675", &create); > +RegisterCamHelper reg678("imx678", &create); > +RegisterCamHelper reg832("imx832", &create); I just realised we haven't got any entries for the camera_sensor_properties for IMX675 and IMX832. Could you update for those as well please ? -- Regards Kieran > > } /* namespace */ > -- > 2.53.0 >
diff --git a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp index 0a0f75e19c01..5e017aaba9e3 100644 --- a/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp +++ b/src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp @@ -50,6 +50,8 @@ CamHelper *create() return new CamHelperStarvis2(); } -RegisterCamHelper reg("imx678", &create); +RegisterCamHelper reg675("imx675", &create); +RegisterCamHelper reg678("imx678", &create); +RegisterCamHelper reg832("imx832", &create); } /* namespace */
These sensors belong to the Starvis 2 family, so add their entires to cam_helper_starvis2. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/ipa/rpi/cam_helper/cam_helper_starvis2.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)