| Message ID | 20261019015712.1817099-1-ragaprasanth@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi 2026. 10. 19. 3:57 keltezéssel, Prasanth R írta: > The frame interval is meant to default to 30fps, > but it is set to 333333/1000000 seconds, which is 3fps. > Use 33333 microseconds instead. > > Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp> > --- > Tested on a Raspberry Pi 4 (32-bit Arm) with a UVC webcam, Looks ok to me. Acked-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > > $ libcamerify v4l2-ctl -d /dev/video0 --all | grep -i 'frames per second' > before: Frames per second: 3.000 (1000000/333333) > after: Frames per second: 30.000 (1000000/33333) > > > src/v4l2/v4l2_camera_proxy.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp > index 554e81f8d..7f8522d5e 100644 > --- a/src/v4l2/v4l2_camera_proxy.cpp > +++ b/src/v4l2/v4l2_camera_proxy.cpp > @@ -274,7 +274,7 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig) > LOG(V4L2Compat, Warning) > << "Camera does not support FrameDurationLimits"; > > - v4l2TimePerFrame_.numerator = 333333; > + v4l2TimePerFrame_.numerator = 33333; > v4l2TimePerFrame_.denominator = 1000000; > } > }
Quoting Prasanth R (2026-10-19 02:57:12) > The frame interval is meant to default to 30fps, > but it is set to 333333/1000000 seconds, which is 3fps. > Use 33333 microseconds instead. > > Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp> Fixes: 77438775b39b ("v4l2: v4l2_camera_proxy: Fix VIDIOC_[GS]_PARM support") Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > Tested on a Raspberry Pi 4 (32-bit Arm) with a UVC webcam, > > $ libcamerify v4l2-ctl -d /dev/video0 --all | grep -i 'frames per second' > before: Frames per second: 3.000 (1000000/333333) > after: Frames per second: 30.000 (1000000/33333) > > > src/v4l2/v4l2_camera_proxy.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp > index 554e81f8d..7f8522d5e 100644 > --- a/src/v4l2/v4l2_camera_proxy.cpp > +++ b/src/v4l2/v4l2_camera_proxy.cpp > @@ -274,7 +274,7 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig) > LOG(V4L2Compat, Warning) > << "Camera does not support FrameDurationLimits"; > > - v4l2TimePerFrame_.numerator = 333333; > + v4l2TimePerFrame_.numerator = 33333; > v4l2TimePerFrame_.denominator = 1000000; > } > } > -- > 2.34.1 >
Hi, Patchwork shows this patch as Superseded, but there is no newer version. It has Acked-by from Barnabás and Reviewed-by from Kieran. Could it be set back so it can be applied? Thanks, Prasanth R On Mon, Oct 19, 2026 at 8:14 PM Kieran Bingham < kieran.bingham@ideasonboard.com> wrote: > Quoting Prasanth R (2026-10-19 02:57:12) > > The frame interval is meant to default to 30fps, > > but it is set to 333333/1000000 seconds, which is 3fps. > > Use 33333 microseconds instead. > > > > Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp> > > Fixes: 77438775b39b ("v4l2: v4l2_camera_proxy: Fix VIDIOC_[GS]_PARM > support") > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > --- > > Tested on a Raspberry Pi 4 (32-bit Arm) with a UVC webcam, > > > > $ libcamerify v4l2-ctl -d /dev/video0 --all | grep -i 'frames per > second' > > before: Frames per second: 3.000 (1000000/333333) > > after: Frames per second: 30.000 (1000000/33333) > > > > > > src/v4l2/v4l2_camera_proxy.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/v4l2/v4l2_camera_proxy.cpp > b/src/v4l2/v4l2_camera_proxy.cpp > > index 554e81f8d..7f8522d5e 100644 > > --- a/src/v4l2/v4l2_camera_proxy.cpp > > +++ b/src/v4l2/v4l2_camera_proxy.cpp > > @@ -274,7 +274,7 @@ void V4L2CameraProxy::setFmtFromConfig(const > StreamConfiguration &streamConfig) > > LOG(V4L2Compat, Warning) > > << "Camera does not support FrameDurationLimits"; > > > > - v4l2TimePerFrame_.numerator = 333333; > > + v4l2TimePerFrame_.numerator = 33333; > > v4l2TimePerFrame_.denominator = 1000000; > > } > > } > > -- > > 2.34.1 > > >
On Wed, Oct 21, 2026 at 09:28:30AM +0900, Prasanth Ramesh wrote: > Hi, > > Patchwork shows this patch as Superseded, but there is no newer version. > It has Acked-by from Barnabás and Reviewed-by from Kieran. > Could it be set back so it can be applied? Done. It was my fault, I set the status of the wrong patch. sorry. > On Mon, Oct 19, 2026 at 8:14 PM Kieran Bingham wrote: > > Quoting Prasanth R (2026-10-19 02:57:12) > > > The frame interval is meant to default to 30fps, > > > but it is set to 333333/1000000 seconds, which is 3fps. > > > Use 33333 microseconds instead. > > > > > > Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp> > > > > Fixes: 77438775b39b ("v4l2: v4l2_camera_proxy: Fix VIDIOC_[GS]_PARM > > support") > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > --- > > > Tested on a Raspberry Pi 4 (32-bit Arm) with a UVC webcam, > > > > > > $ libcamerify v4l2-ctl -d /dev/video0 --all | grep -i 'frames per second' > > > before: Frames per second: 3.000 (1000000/333333) > > > after: Frames per second: 30.000 (1000000/33333) > > > > > > > > > src/v4l2/v4l2_camera_proxy.cpp | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/src/v4l2/v4l2_camera_proxy.cpp > > b/src/v4l2/v4l2_camera_proxy.cpp > > > index 554e81f8d..7f8522d5e 100644 > > > --- a/src/v4l2/v4l2_camera_proxy.cpp > > > +++ b/src/v4l2/v4l2_camera_proxy.cpp > > > @@ -274,7 +274,7 @@ void V4L2CameraProxy::setFmtFromConfig(const > > StreamConfiguration &streamConfig) > > > LOG(V4L2Compat, Warning) > > > << "Camera does not support FrameDurationLimits"; > > > > > > - v4l2TimePerFrame_.numerator = 333333; > > > + v4l2TimePerFrame_.numerator = 33333; > > > v4l2TimePerFrame_.denominator = 1000000; > > > } > > > }
Quoting Prasanth R (2026-10-19 02:57:12) > The frame interval is meant to default to 30fps, > but it is set to 333333/1000000 seconds, which is 3fps. > Use 33333 microseconds instead. > > Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp> I've tried to apply this but the checks fail with: No 'Signed-off-by' trailer matching author 'Prasanth R <ragaprasanth@gmail.com>', see Documentation/contributing.rst Can you confirm which should be author/SoB please? > --- > Tested on a Raspberry Pi 4 (32-bit Arm) with a UVC webcam, > > $ libcamerify v4l2-ctl -d /dev/video0 --all | grep -i 'frames per second' > before: Frames per second: 3.000 (1000000/333333) > after: Frames per second: 30.000 (1000000/33333) > > > src/v4l2/v4l2_camera_proxy.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp > index 554e81f8d..7f8522d5e 100644 > --- a/src/v4l2/v4l2_camera_proxy.cpp > +++ b/src/v4l2/v4l2_camera_proxy.cpp > @@ -274,7 +274,7 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig) > LOG(V4L2Compat, Warning) > << "Camera does not support FrameDurationLimits"; > > - v4l2TimePerFrame_.numerator = 333333; > + v4l2TimePerFrame_.numerator = 33333; > v4l2TimePerFrame_.denominator = 1000000; > } > } > -- > 2.34.1 >
Hi Kieran, Let the author be the SOB Prasanth R <ragaprasanth@gmail.com> Thanks, Prasanth R On Wed, Oct 21, 2026 at 5:47 PM Kieran Bingham < kieran.bingham@ideasonboard.com> wrote: > Quoting Prasanth R (2026-10-19 02:57:12) > > The frame interval is meant to default to 30fps, > > but it is set to 333333/1000000 seconds, which is 3fps. > > Use 33333 microseconds instead. > > > > Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp> > > I've tried to apply this but the checks fail with: > > No 'Signed-off-by' trailer matching author 'Prasanth R < > ragaprasanth@gmail.com>', see Documentation/contributing.rst > > Can you confirm which should be author/SoB please? > > > > > --- > > Tested on a Raspberry Pi 4 (32-bit Arm) with a UVC webcam, > > > > $ libcamerify v4l2-ctl -d /dev/video0 --all | grep -i 'frames per > second' > > before: Frames per second: 3.000 (1000000/333333) > > after: Frames per second: 30.000 (1000000/33333) > > > > > > src/v4l2/v4l2_camera_proxy.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/v4l2/v4l2_camera_proxy.cpp > b/src/v4l2/v4l2_camera_proxy.cpp > > index 554e81f8d..7f8522d5e 100644 > > --- a/src/v4l2/v4l2_camera_proxy.cpp > > +++ b/src/v4l2/v4l2_camera_proxy.cpp > > @@ -274,7 +274,7 @@ void V4L2CameraProxy::setFmtFromConfig(const > StreamConfiguration &streamConfig) > > LOG(V4L2Compat, Warning) > > << "Camera does not support FrameDurationLimits"; > > > > - v4l2TimePerFrame_.numerator = 333333; > > + v4l2TimePerFrame_.numerator = 33333; > > v4l2TimePerFrame_.denominator = 1000000; > > } > > } > > -- > > 2.34.1 > > >
diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index 554e81f8d..7f8522d5e 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -274,7 +274,7 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig) LOG(V4L2Compat, Warning) << "Camera does not support FrameDurationLimits"; - v4l2TimePerFrame_.numerator = 333333; + v4l2TimePerFrame_.numerator = 33333; v4l2TimePerFrame_.denominator = 1000000; } }
The frame interval is meant to default to 30fps, but it is set to 333333/1000000 seconds, which is 3fps. Use 33333 microseconds instead. Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp> --- Tested on a Raspberry Pi 4 (32-bit Arm) with a UVC webcam, $ libcamerify v4l2-ctl -d /dev/video0 --all | grep -i 'frames per second' before: Frames per second: 3.000 (1000000/333333) after: Frames per second: 30.000 (1000000/33333) src/v4l2/v4l2_camera_proxy.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)