| Message ID | 20260930141633.363166-1-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Quoting Barnabás Pőcze (2026-09-30 15:16:33) > The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control > even without any specific tuning, which can be useful. > > And gamma correction provides the manual `Gamma` control, with a default > of 2.2, without which most image will seem too dark. > > So these two algorithms usually have no reason to be missing even > without any sensor specific tuning data. So add them to the rkisp1 > and mali-c55 default tuning files. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/ipa/mali-c55/data/uncalibrated.yaml | 1 + > src/ipa/rkisp1/data/uncalibrated.yaml | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml > index 6dcc0295ca..05c7b448ce 100644 > --- a/src/ipa/mali-c55/data/uncalibrated.yaml > +++ b/src/ipa/mali-c55/data/uncalibrated.yaml > @@ -4,4 +4,5 @@ > version: 1 > algorithms: > - Agc: > + - Ccm: Is there no GammaOutCorrection for Mali-C55 yet ? > ... > diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml > index 609012967e..3057df83b0 100644 > --- a/src/ipa/rkisp1/data/uncalibrated.yaml > +++ b/src/ipa/rkisp1/data/uncalibrated.yaml > @@ -6,4 +6,6 @@ algorithms: > - Agc: > - Awb: > - BlackLevelCorrection: > + - Ccm: > + - GammaOutCorrection: > ... > -- > 2.55.0 >
2026. 10. 01. 12:12 keltezéssel, Kieran Bingham írta: > Quoting Barnabás Pőcze (2026-09-30 15:16:33) >> The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control >> even without any specific tuning, which can be useful. >> >> And gamma correction provides the manual `Gamma` control, with a default >> of 2.2, without which most image will seem too dark. >> >> So these two algorithms usually have no reason to be missing even >> without any sensor specific tuning data. So add them to the rkisp1 >> and mali-c55 default tuning files. >> >> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> >> --- >> src/ipa/mali-c55/data/uncalibrated.yaml | 1 + >> src/ipa/rkisp1/data/uncalibrated.yaml | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml >> index 6dcc0295ca..05c7b448ce 100644 >> --- a/src/ipa/mali-c55/data/uncalibrated.yaml >> +++ b/src/ipa/mali-c55/data/uncalibrated.yaml >> @@ -4,4 +4,5 @@ >> version: 1 >> algorithms: >> - Agc: >> + - Ccm: > > Is there no GammaOutCorrection for Mali-C55 yet ? Not in upstream libcamera, no. > >> ... >> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml >> index 609012967e..3057df83b0 100644 >> --- a/src/ipa/rkisp1/data/uncalibrated.yaml >> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml >> @@ -6,4 +6,6 @@ algorithms: >> - Agc: >> - Awb: >> - BlackLevelCorrection: >> + - Ccm: >> + - GammaOutCorrection: >> ... >> -- >> 2.55.0 >>
Quoting Barnabás Pőcze (2026-10-01 11:14:11) > 2026. 10. 01. 12:12 keltezéssel, Kieran Bingham írta: > > Quoting Barnabás Pőcze (2026-09-30 15:16:33) > >> The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control > >> even without any specific tuning, which can be useful. > >> > >> And gamma correction provides the manual `Gamma` control, with a default > >> of 2.2, without which most image will seem too dark. > >> > >> So these two algorithms usually have no reason to be missing even > >> without any sensor specific tuning data. So add them to the rkisp1 > >> and mali-c55 default tuning files. > >> > >> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > >> --- > >> src/ipa/mali-c55/data/uncalibrated.yaml | 1 + > >> src/ipa/rkisp1/data/uncalibrated.yaml | 2 ++ > >> 2 files changed, 3 insertions(+) > >> > >> diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml > >> index 6dcc0295ca..05c7b448ce 100644 > >> --- a/src/ipa/mali-c55/data/uncalibrated.yaml > >> +++ b/src/ipa/mali-c55/data/uncalibrated.yaml > >> @@ -4,4 +4,5 @@ > >> version: 1 > >> algorithms: > >> - Agc: > >> + - Ccm: > > > > Is there no GammaOutCorrection for Mali-C55 yet ? > > Not in upstream libcamera, no. Ok, well it can add to this file when that gets upstream then! Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > >> ... > >> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml > >> index 609012967e..3057df83b0 100644 > >> --- a/src/ipa/rkisp1/data/uncalibrated.yaml > >> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml > >> @@ -6,4 +6,6 @@ algorithms: > >> - Agc: > >> - Awb: > >> - BlackLevelCorrection: > >> + - Ccm: > >> + - GammaOutCorrection: > >> ... > >> -- > >> 2.55.0 > >> >
diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml index 6dcc0295ca..05c7b448ce 100644 --- a/src/ipa/mali-c55/data/uncalibrated.yaml +++ b/src/ipa/mali-c55/data/uncalibrated.yaml @@ -4,4 +4,5 @@ version: 1 algorithms: - Agc: + - Ccm: ... diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml index 609012967e..3057df83b0 100644 --- a/src/ipa/rkisp1/data/uncalibrated.yaml +++ b/src/ipa/rkisp1/data/uncalibrated.yaml @@ -6,4 +6,6 @@ algorithms: - Agc: - Awb: - BlackLevelCorrection: + - Ccm: + - GammaOutCorrection: ...
The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control even without any specific tuning, which can be useful. And gamma correction provides the manual `Gamma` control, with a default of 2.2, without which most image will seem too dark. So these two algorithms usually have no reason to be missing even without any sensor specific tuning data. So add them to the rkisp1 and mali-c55 default tuning files. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/ipa/mali-c55/data/uncalibrated.yaml | 1 + src/ipa/rkisp1/data/uncalibrated.yaml | 2 ++ 2 files changed, 3 insertions(+)