ipa: rpi: mira220: Drop unused override for hideFramesModeSwitch
diff mbox series

Message ID 20260915110110.2981127-1-jai.luthra@ideasonboard.com
State New
Headers show
Series
  • ipa: rpi: mira220: Drop unused override for hideFramesModeSwitch
Related show

Commit Message

Jai Luthra Sept. 15, 2026, 11:01 a.m. UTC
The hideFramesModeSwitch override is declared but never defined. Drop
it. This fixes IPA runtime errors seen on Raspberry Pi 4 because of
missing symbols.

If the sensor does require skipping frames during mode switch, it needs
to be investigated and fixed in a separate patch.

Fixes: b350edae1801 ("ipa: rpi: cam_helper: Add Mira220 cam helper")
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 src/ipa/rpi/cam_helper/cam_helper_mira220.cpp | 1 -
 1 file changed, 1 deletion(-)

Comments

Kieran Bingham Sept. 15, 2026, 11:25 a.m. UTC | #1
Quoting Jai Luthra (2026-09-15 12:01:10)
> The hideFramesModeSwitch override is declared but never defined. Drop
> it. This fixes IPA runtime errors seen on Raspberry Pi 4 because of
> missing symbols.
> 
> If the sensor does require skipping frames during mode switch, it needs
> to be investigated and fixed in a separate patch.
> 
> Fixes: b350edae1801 ("ipa: rpi: cam_helper: Add Mira220 cam helper")
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  src/ipa/rpi/cam_helper/cam_helper_mira220.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp b/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
> index c884b853b0c1..6ab14890123a 100644
> --- a/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
> +++ b/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
> @@ -17,7 +17,6 @@ public:
>         CamHelperMira220();
>         uint32_t gainCode(double gain) const override;
>         double gain(uint32_t gainCode) const override;
> -       unsigned int hideFramesModeSwitch() const override;
>  
>  private:
>         /*
> -- 
> 2.55.0
>
Barnabás Pőcze Sept. 15, 2026, 11:35 a.m. UTC | #2
2026. 09. 15. 13:01 keltezéssel, Jai Luthra írta:
> The hideFramesModeSwitch override is declared but never defined. Drop
> it. This fixes IPA runtime errors seen on Raspberry Pi 4 because of
> missing symbols.
> 
> If the sensor does require skipping frames during mode switch, it needs
> to be investigated and fixed in a separate patch.
> 
> Fixes: b350edae1801 ("ipa: rpi: cam_helper: Add Mira220 cam helper")
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/ipa/rpi/cam_helper/cam_helper_mira220.cpp | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp b/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
> index c884b853b0c1..6ab14890123a 100644
> --- a/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
> +++ b/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
> @@ -17,7 +17,6 @@ public:
>   	CamHelperMira220();
>   	uint32_t gainCode(double gain) const override;
>   	double gain(uint32_t gainCode) const override;
> -	unsigned int hideFramesModeSwitch() const override;
>   
>   private:
>   	/*

Patch
diff mbox series

diff --git a/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp b/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
index c884b853b0c1..6ab14890123a 100644
--- a/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
+++ b/src/ipa/rpi/cam_helper/cam_helper_mira220.cpp
@@ -17,7 +17,6 @@  public:
 	CamHelperMira220();
 	uint32_t gainCode(double gain) const override;
 	double gain(uint32_t gainCode) const override;
-	unsigned int hideFramesModeSwitch() const override;
 
 private:
 	/*