| Message ID | 20260806152701.4179-1-david.plowman@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi David, Quoting David Plowman (2026-08-06 16:19:40) > Hi > > Version 2 changes only the 2nd patch (Allow black levels to vary with > analogue gain). > > 1. I've made it issue a little warning if you specify constant black > level values that are not used. > > 2. I've actually changed the PWL evaluation so that you get constant > extensions off the ends, rather than linear extrapolation. I don't > think it really matters too much, and it's probably not a thing that > would happen in something calibrated sensibly, but I'm perhaps > slightly more comfortable with this behaviour. (So I haven't added any > extra tags on this one as yet.) > > Thanks! > > David > > David Plowman (4): > ipa: rpi: cam_helper: Increase frameIntegrationDiff for IMX662 > ipa: rpi: Allow black levels to vary with analogue gain > ipa: rpi: Update black level tuning for IMX662 > ipa: rpi: Update colour temperature curve for IMX662 For 2 and 3, I think the only question is understanding how we'll handle more complex black levels? I'll add that as a discussion item for our next call, but in the meanwhile, Patch 1 and 4 look like they could already be merged independently here. Do they make sense on their own ? Should I merge those ? -- Kieran > > src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 19 +++++++-- > src/ipa/rpi/controller/rpi/black_level.cpp | 45 ++++++++++++++++++-- > src/ipa/rpi/controller/rpi/black_level.h | 7 +++ > src/ipa/rpi/pisp/data/imx662.json | 15 ++++++- > src/ipa/rpi/vc4/data/imx662.json | 14 +++++- > 5 files changed, 88 insertions(+), 12 deletions(-) > > -- > 2.47.3 >