| Message ID | 20260907090120.2249140-1-naush@raspberrypi.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Naushir Patuck (2026-09-07 10:01:10) > Override the default value of 1 for mistrustMetadataStartup. This has > been emprically validated. > > Bug: https://github.com/raspberrypi/rpicam-apps/issues/929 > Fixes: 93bed4da915c ("ipa: rpi: Gate CamHelper::prepare() by the mistrust count") > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > index dfc0f602e23b..3f2c93c4011f 100644 > --- a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > @@ -52,6 +52,7 @@ public: > std::pair<uint32_t, uint32_t> getBlanking(Duration &exposure, Duration minFrameDuration, > Duration maxFrameDuration) const override; > bool sensorEmbeddedDataPresent() const override; > + unsigned int mistrustMetadataStartup() const override; > > private: > /* > @@ -162,6 +163,11 @@ bool CamHelperImx477::sensorEmbeddedDataPresent() const > return true; > } > > +unsigned int CamHelperImx477::mistrustMetadataStartup() const > +{ > + return 0; > +} > + > void CamHelperImx477::populateMetadata(const MdParser::RegisterMap ®isters, > Metadata &metadata) const > { > -- > 2.53.0 >
Hi Naush Thanks for the patch. On Mon, 7 Sept 2026 at 20:29, Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > > Quoting Naushir Patuck (2026-09-07 10:01:10) > > Override the default value of 1 for mistrustMetadataStartup. This has > > been emprically validated. > > > > Bug: https://github.com/raspberrypi/rpicam-apps/issues/929 > > Fixes: 93bed4da915c ("ipa: rpi: Gate CamHelper::prepare() by the mistrust count") > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Thanks! David > > > --- > > src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > index dfc0f602e23b..3f2c93c4011f 100644 > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > @@ -52,6 +52,7 @@ public: > > std::pair<uint32_t, uint32_t> getBlanking(Duration &exposure, Duration minFrameDuration, > > Duration maxFrameDuration) const override; > > bool sensorEmbeddedDataPresent() const override; > > + unsigned int mistrustMetadataStartup() const override; > > > > private: > > /* > > @@ -162,6 +163,11 @@ bool CamHelperImx477::sensorEmbeddedDataPresent() const > > return true; > > } > > > > +unsigned int CamHelperImx477::mistrustMetadataStartup() const > > +{ > > + return 0; > > +} > > + > > void CamHelperImx477::populateMetadata(const MdParser::RegisterMap ®isters, > > Metadata &metadata) const > > { > > -- > > 2.53.0 > >
Quoting David Plowman (2026-09-08 08:52:49) > Hi Naush > > Thanks for the patch. > > On Mon, 7 Sept 2026 at 20:29, Kieran Bingham > <kieran.bingham@ideasonboard.com> wrote: > > > > Quoting Naushir Patuck (2026-09-07 10:01:10) > > > Override the default value of 1 for mistrustMetadataStartup. This has > > > been emprically validated. > > > > > > Bug: https://github.com/raspberrypi/rpicam-apps/issues/929 Running checkstyle for patchwork/6169 (aebe4861c087ce9a0cb417151d5316a1fdb2e792..64e5a1411b20ac2d4c2cfe64b58f90a73c01d3b2) 00:04 ------------------------------------------------------------------------------------------------------ 64e5a1411b20ac2d4c2cfe64b58f90a73c01d3b2 ipa: rpi: cam_helper: Set IMX477 mistrustMetadataStartup to 0 ------------------------------------------------------------------------------------------------------ Invalid commit trailer key 'Bug' --- 1 potential issue detected, please review I'll 's/Bug/Closes/' and re-push for integration. -- Kieran > > > Fixes: 93bed4da915c ("ipa: rpi: Gate CamHelper::prepare() by the mistrust count") > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Reviewed-by: David Plowman <david.plowman@raspberrypi.com> > > Thanks! > > David > > > > > > --- > > > src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > index dfc0f602e23b..3f2c93c4011f 100644 > > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > @@ -52,6 +52,7 @@ public: > > > std::pair<uint32_t, uint32_t> getBlanking(Duration &exposure, Duration minFrameDuration, > > > Duration maxFrameDuration) const override; > > > bool sensorEmbeddedDataPresent() const override; > > > + unsigned int mistrustMetadataStartup() const override; > > > > > > private: > > > /* > > > @@ -162,6 +163,11 @@ bool CamHelperImx477::sensorEmbeddedDataPresent() const > > > return true; > > > } > > > > > > +unsigned int CamHelperImx477::mistrustMetadataStartup() const > > > +{ > > > + return 0; > > > +} > > > + > > > void CamHelperImx477::populateMetadata(const MdParser::RegisterMap ®isters, > > > Metadata &metadata) const > > > { > > > -- > > > 2.53.0 > > >
On Tue, 8 Sept 2026 at 11:36, Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > > Quoting David Plowman (2026-09-08 08:52:49) > > Hi Naush > > > > Thanks for the patch. > > > > On Mon, 7 Sept 2026 at 20:29, Kieran Bingham > > <kieran.bingham@ideasonboard.com> wrote: > > > > > > Quoting Naushir Patuck (2026-09-07 10:01:10) > > > > Override the default value of 1 for mistrustMetadataStartup. This has > > > > been emprically validated. > > > > > > > > Bug: https://github.com/raspberrypi/rpicam-apps/issues/929 > > Running checkstyle for patchwork/6169 (aebe4861c087ce9a0cb417151d5316a1fdb2e792..64e5a1411b20ac2d4c2cfe64b58f90a73c01d3b2) 00:04 > ------------------------------------------------------------------------------------------------------ > 64e5a1411b20ac2d4c2cfe64b58f90a73c01d3b2 ipa: rpi: cam_helper: Set IMX477 mistrustMetadataStartup to 0 > ------------------------------------------------------------------------------------------------------ > Invalid commit trailer key 'Bug' > --- > 1 potential issue detected, please review > > > I'll 's/Bug/Closes/' and re-push for integration. Oops sorry, I did it again! I'll definately remember that for next time :) > > -- > Kieran > > > > > > Fixes: 93bed4da915c ("ipa: rpi: Gate CamHelper::prepare() by the mistrust count") > > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > > > > > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > Reviewed-by: David Plowman <david.plowman@raspberrypi.com> > > > > Thanks! > > > > David > > > > > > > > > --- > > > > src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > > index dfc0f602e23b..3f2c93c4011f 100644 > > > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > > @@ -52,6 +52,7 @@ public: > > > > std::pair<uint32_t, uint32_t> getBlanking(Duration &exposure, Duration minFrameDuration, > > > > Duration maxFrameDuration) const override; > > > > bool sensorEmbeddedDataPresent() const override; > > > > + unsigned int mistrustMetadataStartup() const override; > > > > > > > > private: > > > > /* > > > > @@ -162,6 +163,11 @@ bool CamHelperImx477::sensorEmbeddedDataPresent() const > > > > return true; > > > > } > > > > > > > > +unsigned int CamHelperImx477::mistrustMetadataStartup() const > > > > +{ > > > > + return 0; > > > > +} > > > > + > > > > void CamHelperImx477::populateMetadata(const MdParser::RegisterMap ®isters, > > > > Metadata &metadata) const > > > > { > > > > -- > > > > 2.53.0 > > > >
On Tue, Sep 08, 2026 at 11:37:08AM +0100, Naushir Patuck wrote: > On Tue, 8 Sept 2026 at 11:36, Kieran Bingham wrote: > > Quoting David Plowman (2026-09-08 08:52:49) > > > On Mon, 7 Sept 2026 at 20:29, Kieran Bingham wrote: > > > > Quoting Naushir Patuck (2026-09-07 10:01:10) > > > > > Override the default value of 1 for mistrustMetadataStartup. This has > > > > > been emprically validated. > > > > > > > > > > Bug: https://github.com/raspberrypi/rpicam-apps/issues/929 > > > > Running checkstyle for patchwork/6169 (aebe4861c087ce9a0cb417151d5316a1fdb2e792..64e5a1411b20ac2d4c2cfe64b58f90a73c01d3b2) 00:04 > > ------------------------------------------------------------------------------------------------------ > > 64e5a1411b20ac2d4c2cfe64b58f90a73c01d3b2 ipa: rpi: cam_helper: Set IMX477 mistrustMetadataStartup to 0 > > ------------------------------------------------------------------------------------------------------ > > Invalid commit trailer key 'Bug' > > --- > > 1 potential issue detected, please review > > > > > > I'll 's/Bug/Closes/' and re-push for integration. > > Oops sorry, I did it again! > I'll definately remember that for next time :) cp utils/hooks/post-commit .git/hooks/ will ensure you don't forget. > > > > > Fixes: 93bed4da915c ("ipa: rpi: Gate CamHelper::prepare() by the mistrust count") > > > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > > > > > > > > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > > Reviewed-by: David Plowman <david.plowman@raspberrypi.com> > > > > > > Thanks! > > > > > > David > > > > > > > > --- > > > > > src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 6 ++++++ > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > > > index dfc0f602e23b..3f2c93c4011f 100644 > > > > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp > > > > > @@ -52,6 +52,7 @@ public: > > > > > std::pair<uint32_t, uint32_t> getBlanking(Duration &exposure, Duration minFrameDuration, > > > > > Duration maxFrameDuration) const override; > > > > > bool sensorEmbeddedDataPresent() const override; > > > > > + unsigned int mistrustMetadataStartup() const override; > > > > > > > > > > private: > > > > > /* > > > > > @@ -162,6 +163,11 @@ bool CamHelperImx477::sensorEmbeddedDataPresent() const > > > > > return true; > > > > > } > > > > > > > > > > +unsigned int CamHelperImx477::mistrustMetadataStartup() const > > > > > +{ > > > > > + return 0; > > > > > +} > > > > > + > > > > > void CamHelperImx477::populateMetadata(const MdParser::RegisterMap ®isters, > > > > > Metadata &metadata) const > > > > > {
diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp index dfc0f602e23b..3f2c93c4011f 100644 --- a/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp +++ b/src/ipa/rpi/cam_helper/cam_helper_imx477.cpp @@ -52,6 +52,7 @@ public: std::pair<uint32_t, uint32_t> getBlanking(Duration &exposure, Duration minFrameDuration, Duration maxFrameDuration) const override; bool sensorEmbeddedDataPresent() const override; + unsigned int mistrustMetadataStartup() const override; private: /* @@ -162,6 +163,11 @@ bool CamHelperImx477::sensorEmbeddedDataPresent() const return true; } +unsigned int CamHelperImx477::mistrustMetadataStartup() const +{ + return 0; +} + void CamHelperImx477::populateMetadata(const MdParser::RegisterMap ®isters, Metadata &metadata) const {
Override the default value of 1 for mistrustMetadataStartup. This has been emprically validated. Bug: https://github.com/raspberrypi/rpicam-apps/issues/929 Fixes: 93bed4da915c ("ipa: rpi: Gate CamHelper::prepare() by the mistrust count") Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 6 ++++++ 1 file changed, 6 insertions(+)