| Message ID | 20260827105018.2781166-1-paul.elder@ideasonboard.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Am Donnerstag, 27. August 2026, 12:49:53 Mitteleuropäische Sommerzeit schrieb Paul Elder: > This series adds support for the rkisp2 pipeline handler and its IPA. It > supports versions of the ISP supported by the rkisp2 driver (hence the > name) in conjuction with the rkcif driver. The rkisp2 driver is posted > on the list (currently v3) [0] and currently supports the RK3588. > > This pipeline handler implementation only supports memory-to-memory > mode. The RFC version had a patch [1] to support inline mode using shared > media graph [2] which I have removed in v2 to simplify things a little. For camera/media muggles like myself, are there some instructions to follow on how to make that all work? :-) . I seem to have everything set up on the kernel side (camera to vicap / isp2) but don't really know how to connect these. I got the raw media-ctl / gstreamer setup from Michael's series to get something out of the camera side and will try that in the meantime, but seeing the isp2 do something would be great too :-) Thanks a lot Heiko
Hi Heiko, Quoting Heiko Stübner (2026-09-11 18:25:42) > Hi Paul, > > Am Donnerstag, 27. August 2026, 12:49:53 Mitteleuropäische Sommerzeit schrieb Paul Elder: > > This series adds support for the rkisp2 pipeline handler and its IPA. It > > supports versions of the ISP supported by the rkisp2 driver (hence the > > name) in conjuction with the rkcif driver. The rkisp2 driver is posted > > on the list (currently v3) [0] and currently supports the RK3588. > > > > This pipeline handler implementation only supports memory-to-memory > > mode. The RFC version had a patch [1] to support inline mode using shared > > media graph [2] which I have removed in v2 to simplify things a little. > > For camera/media muggles like myself, are there some instructions to > follow on how to make that all work? :-) . Kernel branch here [0] (for orange pi cm5 + base + imx708), libcamera branch here [1], and it should Just Work :) [0] https://git.ideasonboard.com/epaul/linux/commits/branch/epaul/v7.2-rc1/rk3588/rkisp2/upstream-v3 [1] https://git.ideasonboard.com/epaul/libcamera/src/branch/epaul/dev/rkisp2/upstream-v3 > I seem to have everything set up on the kernel side (camera to vicap / isp2) > but don't really know how to connect these. What problem are you having? Or you mean you want to have inline mode? If you want inline mode then you need a few more patches and some modifications to libcamera (unless you want to manually hit media-ctl). You'll need this kernel patch series [2] and this libcamera patch [3]. I don't have any convenient branch so you'll have to apply them yourself on top of the above branches. Note that you might need to update the pad numbers as they have changed between rfc and v3. The libcamera patch *does not* use inline mode; it just supports the shared media graph and configures it to run in memory-to-memory mode (because otherwise it expects the vicap and isp to be in separate media graphs). To get libcamera to use inline mode you'll have to: - Disable the link rkisp2_rawrd0 -> rkisp2_isp - Disable the link rkcif-mipi2 -> rkcif-mipi2-id0 - Enable the link rkcif-mipi2 -> rkisp2_isp in PipelineHandlerRkISP2::configure(); basically the opposite of what patch [3] is doing (while of course updating the pad numbers to v3). For correctness the internal buffer loop between the vicap capture node and isp outout node should be removed too, but in inline mode they would just never be used so you could just leave them in for testing. After those modifications then inline mode in libcamera should Just Work. [2] https://lore.kernel.org/all/20260619052637.1110672-1-paul.elder@ideasonboard.com/ [3] https://patchwork.libcamera.org/patch/27166/ Thanks, Paul > I got the raw media-ctl / gstreamer setup from Michael's series to get > something out of the camera side and will try that in the meantime, but > seeing the isp2 do something would be great too :-) > > > Thanks a lot > Heiko > >