[v2,0/2] Add cmNew to dewarp paremeters
mbox series

Message ID 20260617144858.754729-1-stefan.klug@ideasonboard.com
Headers show
Series
  • Add cmNew to dewarp paremeters
Related show

Message

Stefan Klug June 17, 2026, 2:48 p.m. UTC 
Hi all,

This tiny series adds support for a second camera matrix to the dw100
dewarp implementation (reasoning see patch 2).

Patch 1 contains a bit of preparatory refactoring, patch 2 implements
the feature.

In v2 the union was dropped from DewarpParams to ensure we don't get
into undefined-behavior-land.

Best regards,
Stefan

Stefan Klug (2):
  libcamera: converter: converter_dw100: Refactor dewarp param handling
  libcamera: converter: converter_dw100: Allow to transform between
    different camera matrices

 .../internal/converter/converter_dw100.h      |   7 +-
 .../converter/converter_dw100_vertexmap.h     |  36 ++++-
 src/libcamera/converter/converter_dw100.cpp   |  28 +++-
 .../converter/converter_dw100_vertexmap.cpp   | 131 +++++++++++-------
 4 files changed, 137 insertions(+), 65 deletions(-)

Comments

Kieran Bingham July 8, 2026, 1:05 p.m. UTC | #1 
Quoting Stefan Klug (2026-06-17 15:48:33)
> Hi all,
> 
> This tiny series adds support for a second camera matrix to the dw100
> dewarp implementation (reasoning see patch 2).
> 
> Patch 1 contains a bit of preparatory refactoring, patch 2 implements
> the feature.
> 
> In v2 the union was dropped from DewarpParams to ensure we don't get
> into undefined-behavior-land.

These patches have a small checkpatch style warning but a more difficult
documetnation failure in CI:

https://gitlab.freedesktop.org/camera/libcamera/-/jobs/104412395#L178

> 
> Best regards,
> Stefan
> 
> Stefan Klug (2):
>   libcamera: converter: converter_dw100: Refactor dewarp param handling
>   libcamera: converter: converter_dw100: Allow to transform between
>     different camera matrices
> 
>  .../internal/converter/converter_dw100.h      |   7 +-
>  .../converter/converter_dw100_vertexmap.h     |  36 ++++-
>  src/libcamera/converter/converter_dw100.cpp   |  28 +++-
>  .../converter/converter_dw100_vertexmap.cpp   | 131 +++++++++++-------
>  4 files changed, 137 insertions(+), 65 deletions(-)
> 
> -- 
> 2.53.0
>