| Message ID | 20260626074100.272963-3-robert.mader@collabora.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
2026. 06. 26. 9:41 keltezéssel, Robert Mader írta: > The virtual pipeline is very helpful for debugging purposes and very > small. One big reason to not build it by default in the past was likely > the libyuv dependency, which many distros did not ship by default. > > By now big distros like Debian, Fedora, and others ship libyuv and > already use it when building libcamera. Fedora even enables both test > pipelines by default. > > Thus let's build the virtual pipeline by default, facilitating libcamera > adoption. > > Signed-off-by: Robert Mader <robert.mader@collabora.com> > --- I think this change is ok, it can indeed be useful for debugging, and the virtual cameras won't appear by default. Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 9cd73462f..3b8d54a65 100644 > --- a/meson.build > +++ b/meson.build > @@ -224,7 +224,7 @@ pipelines_support = { > 'simple': ['any'], > 'uvcvideo': ['any'], > 'vimc': ['test'], > - 'virtual': ['test'], > + 'virtual': ['any'], > } > > if wanted_pipelines.contains('all') > -- > 2.54.0 >
Quoting Robert Mader (2026-06-26 08:41:00) > The virtual pipeline is very helpful for debugging purposes and very > small. One big reason to not build it by default in the past was likely > the libyuv dependency, which many distros did not ship by default. > > By now big distros like Debian, Fedora, and others ship libyuv and > already use it when building libcamera. Fedora even enables both test > pipelines by default. > > Thus let's build the virtual pipeline by default, facilitating libcamera > adoption. I'm ok with this because by default the virtual cameras will be off unless a system configuration file is added. Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Signed-off-by: Robert Mader <robert.mader@collabora.com> > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 9cd73462f..3b8d54a65 100644 > --- a/meson.build > +++ b/meson.build > @@ -224,7 +224,7 @@ pipelines_support = { > 'simple': ['any'], > 'uvcvideo': ['any'], > 'vimc': ['test'], > - 'virtual': ['test'], > + 'virtual': ['any'], > } > > if wanted_pipelines.contains('all') > -- > 2.54.0 >
diff --git a/meson.build b/meson.build index 9cd73462f..3b8d54a65 100644 --- a/meson.build +++ b/meson.build @@ -224,7 +224,7 @@ pipelines_support = { 'simple': ['any'], 'uvcvideo': ['any'], 'vimc': ['test'], - 'virtual': ['test'], + 'virtual': ['any'], } if wanted_pipelines.contains('all')
The virtual pipeline is very helpful for debugging purposes and very small. One big reason to not build it by default in the past was likely the libyuv dependency, which many distros did not ship by default. By now big distros like Debian, Fedora, and others ship libyuv and already use it when building libcamera. Fedora even enables both test pipelines by default. Thus let's build the virtual pipeline by default, facilitating libcamera adoption. Signed-off-by: Robert Mader <robert.mader@collabora.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)