| Message ID | 20260618123844.656396-8-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Barnabás On Thu, Jun 18, 2026 at 02:38:24PM +0200, Barnabás Pőcze wrote: > There is no need to check `hasPendingBuffers()` since `completeBuffer()` > return `true` if there are no buffers left to complete in the request. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > index 706681fce5..c3d2695556 100644 > --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > @@ -1131,11 +1131,8 @@ void PipelineHandlerISI::bufferReady(FrameBuffer *buffer) > metadata.set(controls::SensorTimestamp, > buffer->metadata().timestamp); > > - completeBuffer(request, buffer); > - if (request->hasPendingBuffers()) > - return; > - > - completeRequest(request); > + if (completeBuffer(request, buffer)) > + completeRequest(request); > } > > /* Original function taken from simple.cpp */ > -- > 2.54.0 >
On Thu, Jun 18, 2026 at 02:38:24PM +0200, Barnabás Pőcze wrote: > There is no need to check `hasPendingBuffers()` since `completeBuffer()` > return `true` if there are no buffers left to complete in the request. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > index 706681fce5..c3d2695556 100644 > --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > @@ -1131,11 +1131,8 @@ void PipelineHandlerISI::bufferReady(FrameBuffer *buffer) > metadata.set(controls::SensorTimestamp, > buffer->metadata().timestamp); > > - completeBuffer(request, buffer); > - if (request->hasPendingBuffers()) > - return; > - > - completeRequest(request); > + if (completeBuffer(request, buffer)) > + completeRequest(request); > } > > /* Original function taken from simple.cpp */
diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp index 706681fce5..c3d2695556 100644 --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp @@ -1131,11 +1131,8 @@ void PipelineHandlerISI::bufferReady(FrameBuffer *buffer) metadata.set(controls::SensorTimestamp, buffer->metadata().timestamp); - completeBuffer(request, buffer); - if (request->hasPendingBuffers()) - return; - - completeRequest(request); + if (completeBuffer(request, buffer)) + completeRequest(request); } /* Original function taken from simple.cpp */
There is no need to check `hasPendingBuffers()` since `completeBuffer()` return `true` if there are no buffers left to complete in the request. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)