| Message ID | 20260618123844.656396-19-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
On Thu, Jun 18, 2026 at 02:38:35PM +0200, Barnabás Pőcze wrote: > The request cookie is the index of the `CameraCaptureContext` object > not the buffer index, so adjust the comment. > > Fixes: d6cfb080604a ("py: examples: Add simple-continuous-capture.py") > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/py/examples/simple-continuous-capture.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/py/examples/simple-continuous-capture.py b/src/py/examples/simple-continuous-capture.py > index e1cb931e51..5ae841519e 100755 > --- a/src/py/examples/simple-continuous-capture.py > +++ b/src/py/examples/simple-continuous-capture.py > @@ -56,7 +56,7 @@ class CameraCaptureContext: > self.mfbs = {} > > for i in range(num_bufs): > - # Use the buffer index as the "cookie" > + # Use the camera index as the "cookie" > req = cam.create_request(idx) > > buffer = allocator.buffers(stream)[i] > -- > 2.54.0 >
On Thu, Jun 18, 2026 at 02:38:35PM +0200, Barnabás Pőcze wrote: > The request cookie is the index of the `CameraCaptureContext` object > not the buffer index, so adjust the comment. > > Fixes: d6cfb080604a ("py: examples: Add simple-continuous-capture.py") > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/py/examples/simple-continuous-capture.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/py/examples/simple-continuous-capture.py b/src/py/examples/simple-continuous-capture.py > index e1cb931e51..5ae841519e 100755 > --- a/src/py/examples/simple-continuous-capture.py > +++ b/src/py/examples/simple-continuous-capture.py > @@ -56,7 +56,7 @@ class CameraCaptureContext: > self.mfbs = {} > > for i in range(num_bufs): > - # Use the buffer index as the "cookie" > + # Use the camera index as the "cookie" > req = cam.create_request(idx) > > buffer = allocator.buffers(stream)[i]
diff --git a/src/py/examples/simple-continuous-capture.py b/src/py/examples/simple-continuous-capture.py index e1cb931e51..5ae841519e 100755 --- a/src/py/examples/simple-continuous-capture.py +++ b/src/py/examples/simple-continuous-capture.py @@ -56,7 +56,7 @@ class CameraCaptureContext: self.mfbs = {} for i in range(num_bufs): - # Use the buffer index as the "cookie" + # Use the camera index as the "cookie" req = cam.create_request(idx) buffer = allocator.buffers(stream)[i]
The request cookie is the index of the `CameraCaptureContext` object not the buffer index, so adjust the comment. Fixes: d6cfb080604a ("py: examples: Add simple-continuous-capture.py") Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/py/examples/simple-continuous-capture.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)