[RFC,v1,14/27] libcamera: camera: Add missing `span.h` include
diff mbox series

Message ID 20260618123844.656396-15-barnabas.pocze@ideasonboard.com
State Accepted
Headers show
Series
  • Misc. changes before request-buffer split
Related show

Commit Message

Barnabás Pőcze June 18, 2026, 12:38 p.m. UTC
Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 include/libcamera/camera.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Jacopo Mondi June 22, 2026, 1:02 p.m. UTC | #1
Hi Barnabás

On Thu, Jun 18, 2026 at 02:38:31PM +0200, Barnabás Pőcze wrote:

We usually require a commit message

> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  include/libcamera/camera.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h
> index b24a297400..443116b588 100644
> --- a/include/libcamera/camera.h
> +++ b/include/libcamera/camera.h
> @@ -18,6 +18,7 @@
>  #include <libcamera/base/flags.h>
>  #include <libcamera/base/object.h>
>  #include <libcamera/base/signal.h>
> +#include <libcamera/base/span.h>
>
>  #include <libcamera/controls.h>
>  #include <libcamera/geometry.h>
> --
> 2.54.0
>
Laurent Pinchart June 23, 2026, 6:45 p.m. UTC | #2
On Thu, Jun 18, 2026 at 02:38:31PM +0200, Barnabás Pőcze wrote:

With a commit message,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  include/libcamera/camera.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h
> index b24a297400..443116b588 100644
> --- a/include/libcamera/camera.h
> +++ b/include/libcamera/camera.h
> @@ -18,6 +18,7 @@
>  #include <libcamera/base/flags.h>
>  #include <libcamera/base/object.h>
>  #include <libcamera/base/signal.h>
> +#include <libcamera/base/span.h>
>  
>  #include <libcamera/controls.h>
>  #include <libcamera/geometry.h>

Patch
diff mbox series

diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h
index b24a297400..443116b588 100644
--- a/include/libcamera/camera.h
+++ b/include/libcamera/camera.h
@@ -18,6 +18,7 @@ 
 #include <libcamera/base/flags.h>
 #include <libcamera/base/object.h>
 #include <libcamera/base/signal.h>
+#include <libcamera/base/span.h>
 
 #include <libcamera/controls.h>
 #include <libcamera/geometry.h>