[RFC,v1,03/27] libcamera: request: hasPendingBuffers(): Simplify
diff mbox series

Message ID 20260618123844.656396-4-barnabas.pocze@ideasonboard.com
State Accepted
Headers show
Series
  • Misc. changes before request-buffer split
Related show

Commit Message

Barnabás Pőcze June 18, 2026, 12:38 p.m. UTC 
Simplify by calling the equivalent method of the "Private" type.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/request.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi June 22, 2026, 12:28 p.m. UTC | #1 
You could squash with the previous one.
Anyway
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

On Thu, Jun 18, 2026 at 02:38:20PM +0200, Barnabás Pőcze wrote:
> Simplify by calling the equivalent method of the "Private" type.
>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  src/libcamera/request.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
> index e31c9c006a..163d8cf920 100644
> --- a/src/libcamera/request.cpp
> +++ b/src/libcamera/request.cpp
> @@ -575,7 +575,7 @@ uint32_t Request::sequence() const
>   */
>  bool Request::hasPendingBuffers() const
>  {
> -	return !_d()->pending_.empty();
> +	return _d()->hasPendingBuffers();
>  }
>
>  /**
> --
> 2.54.0
>
Laurent Pinchart June 22, 2026, 10:42 p.m. UTC | #2 
The subject line looks a bit weird, I'd write

libcamera: request: Simplify hasPendingBuffers()

On Thu, Jun 18, 2026 at 02:38:20PM +0200, Barnabás Pőcze wrote:
> Simplify by calling the equivalent method of the "Private" type.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/request.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
> index e31c9c006a..163d8cf920 100644
> --- a/src/libcamera/request.cpp
> +++ b/src/libcamera/request.cpp
> @@ -575,7 +575,7 @@ uint32_t Request::sequence() const
>   */
>  bool Request::hasPendingBuffers() const
>  {
> -	return !_d()->pending_.empty();
> +	return _d()->hasPendingBuffers();
>  }
>  
>  /**

Patch
diff mbox series 

diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
index e31c9c006a..163d8cf920 100644
--- a/src/libcamera/request.cpp
+++ b/src/libcamera/request.cpp
@@ -575,7 +575,7 @@  uint32_t Request::sequence() const
  */
 bool Request::hasPendingBuffers() const
 {
-	return !_d()->pending_.empty();
+	return _d()->hasPendingBuffers();
 }
 
 /**